Merge pull request #1247 from swagger-api/resolve-relative-issue

Resolve relative issue

Author: gracekarina

modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/ResolverCache.java

@@ -162,14 +162,6 @@ else if (rootPath != null) {
     }
 
     protected <T> void updateLocalRefs(String file, T result) {
-        if(result instanceof ApiResponse) {
-            ApiResponse response = (ApiResponse) result;
-            if (response.getContent() != null) {
-                for (String mediaType : response.getContent().keySet()) {
-                    updateLocalRefs(file, response.getContent().get(mediaType).getSchema());
-                }
-            }
-        }
         if(result instanceof Parameter){
             Parameter parameter = (Parameter)result;
             if (parameter.getSchema() != null){

modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserTest.java

@@ -1323,6 +1323,25 @@ public void testIssue360() {
         assertEquals(refModel.get$ref(), "#/components/schemas/Pet");
     }
 
+    @Test
+    public void testRelativePath() {
+        OpenAPIV3Parser parser = new OpenAPIV3Parser();
+        ParseOptions options = new ParseOptions();
+        options.setResolve(true);
+        SwaggerParseResult readResult = parser.readLocation("src/test/resources/relative-issue/api.yaml", null, options);
+        Assert.assertEquals(readResult.getOpenAPI().getPaths().get("/scans").getGet().getResponses().get("500").getDescription(), "An error has occurred");
+
+    }
+
+    @Test
+    public void testRelativePath2() {
+        OpenAPIV3Parser parser = new OpenAPIV3Parser();
+        ParseOptions options = new ParseOptions();
+        options.setResolve(true);
+        SwaggerParseResult readResult = parser.readLocation("src/test/resources/codegen-remote-responses/openapi.yaml", null, options);
+        Assert.assertEquals(readResult.getOpenAPI().getPaths().get("/pet/findByTags").getGet().getResponses().get("default").getDescription(), "An error occurred");
+    }
+
     private OpenAPI doRelativeFileTest(String location) {
         OpenAPIV3Parser parser = new OpenAPIV3Parser();
         ParseOptions options = new ParseOptions();

modules/swagger-parser-v3/src/test/resources/codegen-remote-responses/Responses/1.0.0/domain.yaml

@@ -0,0 +1,143 @@
+# OpenAPI version identifier - required for OpenAPI 3.0 domains
+openapi: 3.0.0
+
+#######################
+# Optional info section
+#######################
+info:
+  title: Acme Components
+  description: Common components for Acme REST APIs
+  version: '1.0.0'
+
+components:
+
+  ####################
+  # Common data models
+  ####################
+  schemas:
+    ErrorModel:
+      type: object
+      required:
+        - code
+        - message
+      properties:
+        code:
+          type: integer
+          format: int32
+        message:
+          type: string
+
+  ####################
+  # Common parameters
+  ####################
+  parameters:
+    offsetParam:
+      name: offset
+      in: query
+      schema:
+        type: integer
+        minimum: 0
+      description: The number of items to skip before returning the results
+    limitParam:
+      in: query
+      name: limit
+      schema:
+        type: integer
+        format: int32
+        minimum: 1
+        maximum: 100
+        default: 20
+      description: The number of items to return
+
+  #######################
+  # Common request bodies
+  #######################
+  requestBodies:
+    NewItem:
+      description: A JSON object containing item data
+      required: true
+      content:
+        application/json:
+          schema:
+            type: object
+
+  ####################
+  # Common responses
+  ####################
+  responses:
+    GeneralError:
+      description: An error occurred
+      content:
+        application/json:
+          schema:
+            $ref: '#/components/schemas/ErrorModel'
+      headers:
+        X-RateLimit-Limit:
+          $ref: '#/components/headers/X-RateLimit-Limit'
+        X-RateLimit-Remaining:
+          $ref: '#/components/headers/X-RateLimit-Remaining'
+
+  #########################
+  # Common headers
+  # (except request headers - they are defined as parameters)
+  #########################
+  headers:
+    X-RateLimit-Limit:
+      description: Request limit per hour
+      schema:
+        type: integer
+      example: 100
+    X-RateLimit-Remaining:
+      description: Remaining requests for the hour
+      schema:
+        type: integer
+      example: 94
+
+  #######################
+  # Common path items
+  #######################
+  pathitems:
+    EntityOperations:
+      get:
+        summary: Get all items
+        description: This operation supports pagination
+        parameters:
+          - $ref: '#/components/parameters/offsetParam'
+          - $ref: '#/components/parameters/limitParam'
+        responses:
+          '200':
+            description: A list of items
+          default:
+            $ref: '#/components/responses/GeneralError'
+      post:
+        summary: Add a new item
+        requestBody:
+          $ref: '#/components/requestBodies/NewItem'
+        responses:
+          '201':
+            description: Created
+
+  ######################################
+  # Common examples of input/output data
+  ######################################
+  examples:
+    tshirt:
+      summary: Sample T-shirt data
+      value:
+        # Example value starts here
+        id: 17
+        name: T-shirt
+        description: 100% cotton shirt
+        categories: [clothes]
+
+  #########################
+  # Common link definitions
+  # See: https://swagger.io/docs/specification/links/
+  #########################
+  links: {}
+
+  #########################
+  # Common callback definitions
+  # See: https://swagger.io/docs/specification/callbacks/
+  #########################
+  callbacks: {}