Skip to content

Commit 2b92d44

Browse files
committed
fix tests execution (wiremock update)
1 parent a7c1a74 commit 2b92d44

File tree

6 files changed

+24
-52
lines changed

6 files changed

+24
-52
lines changed

modules/swagger-parser-v3/pom.xml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -73,18 +73,16 @@
7373
<version>${slf4j-version}</version>
7474
<scope>test</scope>
7575
</dependency>
76+
<dependency>
77+
<groupId>com.google.guava</groupId>
78+
<artifactId>guava</artifactId>
79+
<version>32.1.2-jre</version>
80+
<scope>test</scope>
81+
</dependency>
7682
<dependency>
7783
<groupId>com.github.tomakehurst</groupId>
78-
<artifactId>wiremock</artifactId>
79-
<version>${wiremock-version}</version>
84+
<artifactId>wiremock-jre8</artifactId>
8085
<scope>test</scope>
81-
82-
<exclusions>
83-
<exclusion>
84-
<groupId>*</groupId>
85-
<artifactId>*</artifactId>
86-
</exclusion>
87-
</exclusions>
8886
</dependency>
8987
<dependency>
9088
<groupId>junit</groupId>

modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/CustomOpenAPIDereferencer.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,25 @@ public Visitor buildReferenceVisitor(DereferencerContext context, Reference refe
1919
return new CustomVisitor(reference, (OpenAPI31Traverser)traverser, new HashSet<>(), new HashMap<>());
2020
}
2121

22+
@Override
23+
public ReferenceVisitor buildReferenceVisitorWithContext(DereferencerContext context, Reference reference, Traverser traverser) {
24+
return new CustomVisitor(reference, (OpenAPI31Traverser)traverser, new HashSet<>(), new HashMap<>(), context);
25+
}
26+
2227
static public class CustomVisitor extends ReferenceVisitor {
2328

2429
public CustomVisitor(Reference reference, OpenAPI31Traverser openAPITraverser, HashSet<Object> visited,
2530
HashMap<Object, Object> visitedMap) {
2631
super(reference, openAPITraverser, visited, visitedMap);
2732
}
33+
public CustomVisitor(
34+
Reference reference,
35+
OpenAPI31Traverser openAPITraverser,
36+
HashSet<Object> visited,
37+
HashMap<Object, Object> visitedMap,
38+
DereferencerContext context) {
39+
super(reference, openAPITraverser, visited, visitedMap, context);
40+
}
2841

2942
@Override
3043
public String readHttp(String uri, List<AuthorizationValue> auths) throws Exception {

modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIResolverTest.java

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import com.github.tomakehurst.wiremock.client.WireMock;
99
import com.github.tomakehurst.wiremock.core.WireMockConfiguration;
1010
import io.swagger.v3.core.util.Json;
11-
import io.swagger.v3.core.util.Yaml;
1211
import io.swagger.v3.oas.models.Components;
1312
import io.swagger.v3.oas.models.OpenAPI;
1413
import io.swagger.v3.oas.models.Operation;
@@ -34,20 +33,14 @@
3433
import io.swagger.v3.oas.models.security.SecurityScheme;
3534
import io.swagger.v3.parser.OpenAPIResolver;
3635
import io.swagger.v3.parser.OpenAPIV3Parser;
37-
import io.swagger.v3.parser.ResolverCache;
3836
import io.swagger.v3.parser.core.models.AuthorizationValue;
3937
import io.swagger.v3.parser.core.models.ParseOptions;
4038
import io.swagger.v3.parser.core.models.SwaggerParseResult;
41-
import io.swagger.v3.parser.processors.ComponentsProcessor;
42-
import io.swagger.v3.parser.processors.PathsProcessor;
4339
import io.swagger.v3.parser.reference.DereferencerContext;
4440
import io.swagger.v3.parser.reference.DereferencersFactory;
4541
import io.swagger.v3.parser.reference.OpenAPIDereferencer;
4642
import io.swagger.v3.parser.util.OpenAPIDeserializer;
4743
import io.swagger.v3.parser.util.ResolverFully;
48-
import mockit.Injectable;
49-
import mockit.Mocked;
50-
import mockit.Expectations;
5144
import org.apache.commons.io.FileUtils;
5245
import org.testng.Assert;
5346
import org.testng.annotations.AfterClass;
@@ -79,12 +72,7 @@
7972

8073
public class OpenAPIResolverTest {
8174

82-
@Injectable OpenAPI swagger;
8375
List<AuthorizationValue> auths = new ArrayList<>();
84-
@Mocked ResolverCache cache;
85-
@Injectable ParseOptions parseOptions;
86-
@Mocked ComponentsProcessor componentsProcessor;
87-
@Mocked PathsProcessor pathsProcessor;
8876

8977
protected int serverPort = getDynamicPort();
9078
protected WireMockServer wireMockServer;
@@ -1065,33 +1053,6 @@ public void allOfExampleGeneration() throws JsonProcessingException {
10651053
Assert.assertEquals("{\"someProperty\":\"ABC\",\"someOtherProperty\":42}", Json.mapper().writeValueAsString(withExample));
10661054
}
10671055

1068-
@Test
1069-
public void testSwaggerResolver() throws Exception {
1070-
1071-
new Expectations() {{
1072-
new ResolverCache(swagger, auths, null, new HashSet<>(), parseOptions);
1073-
result = cache;
1074-
times = 1;
1075-
1076-
new ComponentsProcessor(swagger, cache);
1077-
result = componentsProcessor;
1078-
times = 1;
1079-
1080-
new PathsProcessor(cache, swagger, withInstanceOf(OpenAPIResolver.Settings.class));
1081-
result = pathsProcessor;
1082-
times = 1;
1083-
1084-
pathsProcessor.processPaths();
1085-
times = 1;
1086-
1087-
componentsProcessor.processComponents();
1088-
times = 1;
1089-
1090-
}};
1091-
1092-
assertEquals(new OpenAPIResolver(swagger, auths, null, null, parseOptions).resolve(), swagger);
1093-
}
1094-
10951056
@Test
10961057
public void testSwaggerResolver_NullSwagger() throws Exception {
10971058
assertNull(new OpenAPIResolver(null, null, null).resolve());

modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserRemoteResolvingTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ public void testInlineModelResolverByUrl(){
302302
@Test
303303
public void testIssueSameRefsDifferentModel() throws IOException {
304304
String pathFile = FileUtils.readFileToString(new File("src/test/resources/same-refs-different-model-domain.yaml"), "UTF-8");
305-
WireMock.stubFor(get(urlPathMatching("/issue-domain"))
305+
WireMock.stubFor(get(urlPathMatching("/issue-domain/"))
306306
.willReturn(aResponse()
307307
.withStatus(HttpURLConnection.HTTP_OK)
308308
.withHeader("Content-type", "application/json")

modules/swagger-parser/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
</dependency>
7373
<dependency>
7474
<groupId>com.github.tomakehurst</groupId>
75-
<artifactId>wiremock</artifactId>
75+
<artifactId>wiremock-jre8</artifactId>
7676
<version>${wiremock-version}</version>
7777
<scope>test</scope>
7878
<exclusions>

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@
374374
</dependency>
375375
<dependency>
376376
<groupId>com.github.tomakehurst</groupId>
377-
<artifactId>wiremock</artifactId>
377+
<artifactId>wiremock-jre8</artifactId>
378378
<version>${wiremock-version}</version>
379379
<scope>test</scope>
380380
</dependency>
@@ -421,7 +421,7 @@
421421
<junit-version>4.13.2</junit-version>
422422
<testng-version>7.8.0</testng-version>
423423
<jmockit-version>1.49</jmockit-version>
424-
<wiremock-version>2.27.2</wiremock-version>
424+
<wiremock-version>2.35.0</wiremock-version>
425425
<surefire-version>3.0.0</surefire-version>
426426
<commons-lang-version>3.12.0</commons-lang-version>
427427
<jackson-version>2.15.1</jackson-version>

0 commit comments

Comments
 (0)