fix for issue #1309

Author: gracekarina

modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/OpenAPIDeserializer.java

@@ -260,7 +260,7 @@ public Components getComponents(ObjectNode obj, String location, ParseResult res
         }
         node = getObject("examples",obj,false,location,result);
         if(node != null) {
-            components.setExamples(getExamples(node, String.format("%s.%s", location, "examples"),result));
+            components.setExamples(getExamples(node, String.format("%s.%s", location, "examples"),result,true));
         }
 
         node = getObject("requestBodies",obj,false,location,result);
@@ -992,7 +992,7 @@ public MediaType getMediaType(ObjectNode contentNode, String location, ParseResu
 
         ObjectNode examplesObject = getObject("examples",contentNode,false,location,result);
         if(examplesObject!=null) {
-            mediaType.setExamples(getExamples(examplesObject, String.format("%s.%s", location, "examples"), result));
+            mediaType.setExamples(getExamples(examplesObject, String.format("%s.%s", location, "examples"), result, false));
         }
 
         Object example = getAnyExample("example",contentNode, location,result);
@@ -1565,7 +1565,7 @@ public Parameter getParameter(ObjectNode obj, String location, ParseResult resul
 
         ObjectNode examplesObject = getObject("examples",obj,false,location,result);
         if(examplesObject!=null) {
-            parameter.setExamples(getExamples(examplesObject, String.format("%s.%s", location, "examples"), result));
+            parameter.setExamples(getExamples(examplesObject, String.format("%s.%s", location, "examples"), result,false));
         }
 
         Object example = getAnyExample("example", obj, location,result);
@@ -1683,7 +1683,7 @@ public Header getHeader(ObjectNode headerNode, String location, ParseResult resu
 
         ObjectNode examplesObject = getObject("examples",headerNode,false,location,result);
         if(examplesObject!=null) {
-            header.setExamples(getExamples(examplesObject, location, result));
+            header.setExamples(getExamples(examplesObject, location, result, false));
         }
 
         Object example = getAnyExample("example", headerNode, location,result);
@@ -2521,17 +2521,19 @@ private byte[] toBytes( String byteString) {
 
 
 
-    public Map<String, Example> getExamples(ObjectNode obj, String location, ParseResult result) {
+    public Map<String, Example> getExamples(ObjectNode obj, String location, ParseResult result, boolean  UnderComponents) {
         if (obj == null) {
             return null;
         }
         Map<String, Example> examples = new LinkedHashMap<>();
 
         Set<String> exampleKeys = getKeys(obj);
         for(String exampleName : exampleKeys) {
-            if (!Pattern.matches("^[a-zA-Z0-9\\.\\-_]+$",
-                            exampleName)) {
-                result.warning(location, "Example name "+ exampleName + " doesn't adhere to regular expression ^[a-zA-Z0-9\\.\\-_]+$");
+            if(UnderComponents) {
+                if (!Pattern.matches("^[a-zA-Z0-9\\.\\-_]+$",
+                        exampleName)) {
+                    result.warning(location, "Example name " + exampleName + " doesn't adhere to regular expression ^[a-zA-Z0-9\\.\\-_]+$");
+                }
             }
 
             JsonNode exampleValue = obj.get(exampleName);

modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserTest.java

@@ -66,6 +66,18 @@ public class OpenAPIV3ParserTest {
     protected int serverPort = getDynamicPort();
     protected WireMockServer wireMockServer;
 
+    @Test
+    public void testIssue1309() {
+        OpenAPIV3Parser openApiParser = new OpenAPIV3Parser();
+        ParseOptions options = new ParseOptions();
+        options.setResolve(true);
+        SwaggerParseResult parseResult = openApiParser.readLocation("issue-1309.yaml", null, options);
+
+        OpenAPI openAPI = parseResult.getOpenAPI();
+        assertNotNull(openAPI);
+        assertEquals(parseResult.getMessages().get(0),"attribute components.schemas.customer-not-found.examples is unexpected");
+    }
+
     @Test
     public void testIssue1316() {
         OpenAPIV3Parser openApiParser = new OpenAPIV3Parser();
@@ -76,7 +88,6 @@ public void testIssue1316() {
         OpenAPI openAPI = parseResult.getOpenAPI();
         assertNotNull(openAPI);
         assertTrue(parseResult.getMessages().size() == 0);
-
     }
 
 

modules/swagger-parser-v3/src/test/resources/issue-1309.yaml

@@ -0,0 +1,27 @@
+---
+openapi: 3.0.1
+info:
+  title: Regular Expression Issue
+  version: 0.0.2
+paths:
+  "/test":
+    get:
+      responses:
+        '200':
+          description: It works
+        '400':
+          description: Bad Request
+          content:
+            application/json:
+              schema:
+                type: object
+              examples:
+                Entity not found:
+                  summary: Item not existing
+components:
+  schemas:
+    customer-not-found:
+      type: object
+      examples:
+        Customer not found:
+          summary: Customer not existing