Skip to content

Commit 56751fa

Browse files
authored
Merge pull request #967 from OpenAPITools/preserve-body-parameter-name
Ensure the body parameter name is preserved
2 parents 0468ac2 + bc172be commit 56751fa

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

modules/swagger-parser-v2-converter/src/main/java/io/swagger/v3/parser/converter/SwaggerConverter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -574,6 +574,7 @@ public Operation convert(io.swagger.models.Operation v2Operation) {
574574
}
575575
operation.setDeprecated(v2Operation.isDeprecated());
576576
operation.setOperationId(v2Operation.getOperationId());
577+
operation.setExtensions(convert(v2Operation.getVendorExtensions()));
577578

578579
operation.setTags(v2Operation.getTags());
579580

@@ -585,6 +586,7 @@ public Operation convert(io.swagger.models.Operation v2Operation) {
585586
formParams.add(param);
586587
} else if ("body".equals(param.getIn())) {
587588
operation.setRequestBody(convertParameterToRequestBody(param, v2Operation.getConsumes()));
589+
operation.addExtension("x-codegen-request-body-name", param.getName());
588590
} else {
589591
Parameter convert = convert(param);
590592
String $ref = convert.get$ref();
@@ -631,8 +633,6 @@ public Operation convert(io.swagger.models.Operation v2Operation) {
631633
operation.setSecurity(convertSecurityRequirementsMap(v2Operation.getSecurity()));
632634
}
633635

634-
operation.setExtensions(convert(v2Operation.getVendorExtensions()));
635-
636636
return operation;
637637
}
638638

modules/swagger-parser-v2-converter/src/test/java/io/swagger/parser/test/V2ConverterTest.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -678,8 +678,15 @@ public void testIssue758() throws Exception {
678678
public void testIssue762() throws Exception {
679679
final OpenAPI oas = getConvertedOpenAPIFromJsonFile(ISSUE_762_JSON);
680680
assertNotNull(oas);
681-
}
682-
681+
}
682+
683+
@Test(description = "OpenAPI v2 Converter: Ensure body name is preserved in x-codegen-request-body-name extension")
684+
public void testPreserveBodyParameterName() throws Exception {
685+
final OpenAPI oas = getConvertedOpenAPIFromJsonFile(ISSUE_762_JSON);
686+
assertNotNull(oas);
687+
assertEquals(oas.getPaths().get("/").getPut().getExtensions().get("x-codegen-request-body-name"), "pet");
688+
}
689+
683690
@Test(description = "requestBody not correctly populated when Parameters is a list of $refs (OAS 2 to 3 conversion)")
684691
public void testIssue765() throws Exception {
685692
final OpenAPI oas = getConvertedOpenAPIFromJsonFile(ISSUE_765_YAML);

0 commit comments

Comments
 (0)