Skip to content

Commit 929f9bc

Browse files
committed
fix regression #943
1 parent 8207499 commit 929f9bc

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/ResolverFully.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ public Schema resolveSchema(Schema schema) {
314314
Schema innerProperty = obj.getProperties().get(propertyName);
315315
// reference check
316316
if(schema != innerProperty) {
317-
if(resolvedProperties.get(propertyName) == null && resolvedProperties.get(propertyName) != innerProperty) {
317+
if(resolvedProperties.get(propertyName) == null || resolvedProperties.get(propertyName) != innerProperty) {
318318
LOGGER.debug("avoiding infinite loop");
319319
Schema resolved = resolveSchema(innerProperty);
320320
updated.put(propertyName, resolved);
@@ -354,7 +354,7 @@ public Schema resolveSchema(Schema schema) {
354354
if (resolved.getProperties() != null) {
355355
for (String key : properties.keySet()) {
356356
Schema prop = (Schema) resolved.getProperties().get(key);
357-
if(resolvedProperties.get(key) == null && resolvedProperties.get(key) != prop) {
357+
if(resolvedProperties.get(key) == null || resolvedProperties.get(key) != prop) {
358358
LOGGER.debug("avoiding infinite loop");
359359
Schema resolvedProp = resolveSchema(prop);
360360
model.addProperties(key,resolvedProp );
@@ -402,7 +402,7 @@ public Schema resolveSchema(Schema schema) {
402402
if (resolved.getProperties() != null) {
403403
for (String key : properties.keySet()) {
404404
Schema prop = (Schema) resolved.getProperties().get(key);
405-
if(resolvedProperties.get(key) == null && resolvedProperties.get(key) != prop) {
405+
if(resolvedProperties.get(key) == null || resolvedProperties.get(key) != prop) {
406406
LOGGER.debug("avoiding infinite loop");
407407
Schema resolvedProp = resolveSchema(prop);
408408
model.addProperties(key,resolvedProp );
@@ -451,7 +451,7 @@ public Schema resolveSchema(Schema schema) {
451451
if (resolved.getProperties() != null) {
452452
for (String key : properties.keySet()) {
453453
Schema prop = (Schema) resolved.getProperties().get(key);
454-
if(resolvedProperties.get(key) == null && resolvedProperties.get(key) != prop) {
454+
if(resolvedProperties.get(key) == null || resolvedProperties.get(key) != prop) {
455455
LOGGER.debug("avoiding infinite loop");
456456
Schema resolvedProp = resolveSchema(prop);
457457
model.addProperties(key,resolvedProp );
@@ -507,7 +507,7 @@ public Schema resolveSchema(Schema schema) {
507507
Map<String, Schema> properties = model.getProperties();
508508
for (String propertyName : properties.keySet()) {
509509
Schema property = (Schema) model.getProperties().get(propertyName);
510-
if(resolvedProperties.get(propertyName) == null && resolvedProperties.get(propertyName) != property) {
510+
if(resolvedProperties.get(propertyName) == null || resolvedProperties.get(propertyName) != property) {
511511
LOGGER.debug("avoiding infinite loop");
512512
Schema resolved = resolveSchema(property);
513513
updated.put(propertyName, resolved);

0 commit comments

Comments
 (0)