Merge pull request #716 from ackintosh/fix-swaggerparseresult-message

Fix missing SwaggerParseResult.message

Author: frantuma

modules/swagger-parser-v2-converter/src/main/java/io/swagger/v3/parser/converter/SwaggerConverter.java

@@ -126,14 +126,13 @@ public SwaggerParseResult convert(SwaggerDeserializationResult parse) {
             return null;
         }
 
+        SwaggerParseResult output = new SwaggerParseResult().messages(parse.getMessages());
+
         if (parse.getSwagger() == null) {
-            return new SwaggerParseResult()
-                    .messages(parse.getMessages());
+            return output;
         }
 
         OpenAPI openAPI = new OpenAPI();
-        SwaggerParseResult output = new SwaggerParseResult();
-
         SwaggerInventory inventory = new SwaggerInventory().process(parse.getSwagger());
 
         Swagger swagger = parse.getSwagger();

modules/swagger-parser-v2-converter/src/test/java/io/swagger/parser/test/V2ConverterTest.java

@@ -639,6 +639,17 @@ public void testParameterConversion() throws Exception {
         assertFalse(parameter.getExplode());
     }
 
+    @Test(description = "OpenAPI v2 converter - SwaggerParseResult has message")
+    public void testSwaggerParseResultHasMessage() throws Exception {
+        SwaggerConverter converter = new SwaggerConverter();
+        String swaggerAsString = new String(Files.readAllBytes(Paths.get(getClass().getClassLoader().getResource(PET_STORE_JSON).toURI())));
+        ParseOptions parseOptions = new ParseOptions();
+        parseOptions.setResolve(false);
+        SwaggerParseResult result = converter.readContents(swaggerAsString, null, parseOptions);
+
+        assertNotNull(result.getMessages());
+    }
+
     private OpenAPI getConvertedOpenAPIFromJsonFile(String file) throws IOException, URISyntaxException {
         SwaggerConverter converter = new SwaggerConverter();
         String swaggerAsString = new String(Files.readAllBytes(Paths.get(getClass().getClassLoader().getResource(file).toURI())));