Skip to content

Commit e6255f8

Browse files
authored
Merge pull request #1317 from swagger-api/issue-1316
fix for issue #1316: ContentType in Encoding Object should not be required.
2 parents 2b07ea9 + baf2fe9 commit e6255f8

File tree

3 files changed

+39
-1
lines changed

3 files changed

+39
-1
lines changed

modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/OpenAPIDeserializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1033,7 +1033,7 @@ public Encoding getEncoding(ObjectNode node, String location, ParseResult result
10331033

10341034
Encoding encoding = new Encoding();
10351035

1036-
String value = getString("contentType", node, true, location, result);
1036+
String value = getString("contentType", node, false, location, result);
10371037
encoding.setContentType(value);
10381038

10391039
value = getString("style", node, false, location, result);

modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,19 @@ public class OpenAPIV3ParserTest {
6666
protected int serverPort = getDynamicPort();
6767
protected WireMockServer wireMockServer;
6868

69+
@Test
70+
public void testIssue1316() {
71+
OpenAPIV3Parser openApiParser = new OpenAPIV3Parser();
72+
ParseOptions options = new ParseOptions();
73+
options.setResolve(true);
74+
SwaggerParseResult parseResult = openApiParser.readLocation("Issue1316.yaml", null, options);
75+
76+
OpenAPI openAPI = parseResult.getOpenAPI();
77+
assertNotNull(openAPI);
78+
assertTrue(parseResult.getMessages().size() == 0);
79+
80+
}
81+
6982

7083
@Test
7184
public void testFlattenComposedSchema() {
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
---
2+
openapi: 3.0.1
3+
info:
4+
title: Encoding Issue
5+
version: 0.0.2
6+
paths:
7+
"/uploads":
8+
post:
9+
tags:
10+
- Uploads
11+
requestBody:
12+
content:
13+
multipart/form-data:
14+
schema:
15+
type: object
16+
properties:
17+
file:
18+
type: string
19+
format: binary
20+
encoding:
21+
file:
22+
style: form
23+
responses:
24+
'200':
25+
description: Success

0 commit comments

Comments
 (0)