fix: gracefully handle empty request bodies (via #4859)

Author: shockey

src/core/plugins/oas3/components/request-body.jsx

@@ -29,12 +29,12 @@ const RequestBody = ({
 
   const mediaTypeValue = requestBodyContent.get(contentType)
 
-  const isObjectContent = mediaTypeValue.getIn(["schema", "type"]) === "object"
-
   if(!mediaTypeValue) {
     return null
   }
 
+  const isObjectContent = mediaTypeValue.getIn(["schema", "type"]) === "object"
+
   if(
     contentType === "application/octet-stream"
     || contentType.indexOf("image/") === 0

src/core/plugins/oas3/wrap-components/parameters.jsx

@@ -1,6 +1,6 @@
 import React, { Component } from "react"
 import PropTypes from "prop-types"
-import Im, { Map } from "immutable"
+import Im, { Map, List } from "immutable"
 import ImPropTypes from "react-immutable-proptypes"
 import { OAS3ComponentWrapFactory } from "../helpers"
 
@@ -177,7 +177,7 @@ class Parameters extends Component {
               <label>
                 <ContentType
                   value={oas3Selectors.requestContentType(...pathMethod)}
-                  contentTypes={ requestBody.get("content").keySeq() }
+                  contentTypes={ requestBody.get("content", List()).keySeq() }
                   onChange={(value) => {
                     oas3Actions.setRequestContentType({ value, pathMethod })
                   }}

test/e2e-cypress/static/documents/bugs/4838.yaml

@@ -0,0 +1,12 @@
+openapi: "3.0.0"
+
+paths:
+  /some/route:
+    post:
+      description: This should be visible
+      tags:
+        - Some
+      requestBody: {}
+      responses:
+        '200':
+          description: Description

test/e2e-cypress/tests/bugs/4838.js

@@ -0,0 +1,11 @@
+import repeat from "lodash/repeat"
+
+describe("#4838: empty request bodies result in endless loading", () => {
+  it("should render model content changes correctly", () => {
+    cy
+      .visit("/?url=/documents/bugs/4838.yaml")
+      .get("#operations-Some-post_some_route")
+      .click()
+      .contains("This should be visible")
+  })
+})