improvement: prevent loading resources from third party CDN (via #4598)

markuspoerschke · shockey · commit 875caab173b1 · 2018-07-05T21:55:25.000-05:00
Remove usage of Google Fonts to avoid any data protection issue. Using a
CDN will leak data to a third party that can be simply avoided by using
system fonts instead.

Furthermore the usage of CDNs can cause legal issues in EU countries.
diff --git a/dev-helpers/index.html b/dev-helpers/index.html
@@ -5,7 +5,6 @@
   <meta charset="UTF-8">
   <meta name="viewport" content="width=device-width, initial-scale=1">
   <title>Swagger UI</title>
-  <link href="https://fonts.googleapis.com/css?family=Open+Sans:400,700|Source+Code+Pro:300,600|Titillium+Web:400,600,700" rel="stylesheet">
   <link rel="stylesheet" type="text/css" href="./swagger-ui.css" >
   <link rel="icon" type="image/png" href="./favicon-32x32.png" sizes="32x32" />
   <link rel="icon" type="image/png" href="./favicon-16x16.png" sizes="16x16" />
diff --git a/dist/index.html b/dist/index.html
@@ -4,7 +4,6 @@
   <head>
     <meta charset="UTF-8">
     <title>Swagger UI</title>
-    <link href="https://fonts.googleapis.com/css?family=Open+Sans:400,700|Source+Code+Pro:300,600|Titillium+Web:400,600,700" rel="stylesheet">
     <link rel="stylesheet" type="text/css" href="./swagger-ui.css" >
     <link rel="icon" type="image/png" href="./favicon-32x32.png" sizes="32x32" />
     <link rel="icon" type="image/png" href="./favicon-16x16.png" sizes="16x16" />
diff --git a/src/style/_type.scss b/src/style/_type.scss
@@ -1,21 +1,21 @@
 @mixin text_body($color: $text-body-default-font-color)
 {
-    font-family: 'Open Sans', sans-serif;
+    font-family: sans-serif;
 
     color: $color;
 }
 
 @mixin text_code($color: $text-code-default-font-color)
 {
-    font-family: 'Source Code Pro', monospace;
+    font-family: monospace;
     font-weight: 600;
 
     color: $color;
 }
 
 @mixin text_headline($color: $text-headline-default-font-color)
 {
-    font-family: 'Titillium Web', sans-serif;
+    font-family: sans-serif;
 
     color: $color;
 }
diff --git a/test/e2e/helpers/index.html b/test/e2e/helpers/index.html
@@ -5,7 +5,6 @@
   <meta charset="UTF-8">
   <meta name="viewport" content="width=device-width, initial-scale=1">
   <title>Swagger UI</title>
-  <link href="https://fonts.googleapis.com/css?family=Open+Sans:400,700|Source+Code+Pro:300,600|Titillium+Web:400,600,700" rel="stylesheet">
   <link rel="stylesheet" type="text/css" href="./swagger-ui.css" >
   <link rel="icon" type="image/png" href="./favicon-32x32.png" sizes="32x32" />
   <link rel="icon" type="image/png" href="./favicon-16x16.png" sizes="16x16" />

Original file line number	Diff line number	Diff line change
`@@ -1,21 +1,21 @@`
`1`	`1`	`@mixin text_body($color: $text-body-default-font-color)`
`2`	`2`	`{`
`3`		`- font-family: 'Open Sans', sans-serif;`
	`3`	`+ font-family: sans-serif;`
`4`	`4`
`5`	`5`	`color: $color;`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`@mixin text_code($color: $text-code-default-font-color)`
`9`	`9`	`{`
`10`		`- font-family: 'Source Code Pro', monospace;`
	`10`	`+ font-family: monospace;`
`11`	`11`	`font-weight: 600;`
`12`	`12`
`13`	`13`	`color: $color;`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`@mixin text_headline($color: $text-headline-default-font-color)`
`17`	`17`	`{`
`18`		`- font-family: 'Titillium Web', sans-serif;`
	`18`	`+ font-family: sans-serif;`
`19`	`19`
`20`	`20`	`color: $color;`
`21`	`21`	`}`