Skip to content

Commit 8c90d5d

Browse files
authored
fix: distribute proper source maps in npm distribution packages (#9877)
Refs #9101
1 parent b6805e5 commit 8c90d5d

File tree

8 files changed

+14
-17
lines changed

8 files changed

+14
-17
lines changed

.npmignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,8 @@
66
!dist/swagger-ui.js
77
!dist/swagger-ui.js.map
88
!dist/swagger-ui-bundle.js
9-
!dist/swagger-ui-bundle.js.map
109
!dist/swagger-ui-standalone-preset.js
11-
!dist/swagger-ui-standalone-preset.js.map
1210
!dist/swagger-ui-es-bundle.js
13-
!dist/swagger-ui-es-bundle.js.map
1411
!dist/swagger-ui-es-bundle-core.js
1512
!dist/swagger-ui-es-bundle-core.js.map
1613
!dist/swagger-ui.css

flavors/swagger-ui-react/release/run.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@ cp ../../../dist/swagger-ui-es-bundle-core.js.map ../dist
1414
cp ../../../dist/swagger-ui.js ../dist
1515
cp ../../../dist/swagger-ui.js.map ../dist
1616
cp ../../../dist/swagger-ui-bundle.js ../dist
17-
cp ../../../dist/swagger-ui-bundle.js.map ../dist
1817
cp ../../../dist/swagger-ui-es-bundle.js ../dist
19-
cp ../../../dist/swagger-ui-es-bundle.js.map ../dist
2018
cp ../../../dist/swagger-ui.css ../dist
2119
cp ../../../dist/swagger-ui.css.map ../dist
2220

webpack/_config-builder.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const webpack = require("webpack")
88
const TerserPlugin = require("terser-webpack-plugin")
99
const nodeExternals = require("webpack-node-externals")
1010

11-
const { getRepoInfo } = require("./_helpers")
11+
const { getRepoInfo, getDevtool } = require("./_helpers")
1212
const pkg = require("../package.json")
1313

1414
const projectBasePath = path.join(__dirname, "../")
@@ -129,13 +129,7 @@ function buildConfig(
129129
},
130130
},
131131

132-
// If we're mangling, size is a concern -- so use trace-only sourcemaps
133-
// Otherwise, provide heavy souremaps suitable for development
134-
devtool: sourcemaps
135-
? minimize
136-
? "nosources-source-map"
137-
: "cheap-module-source-map"
138-
: false,
132+
devtool: getDevtool(sourcemaps, minimize),
139133

140134
performance: {
141135
hints: "error",
@@ -149,6 +143,7 @@ function buildConfig(
149143
(compiler) =>
150144
new TerserPlugin({
151145
terserOptions: {
146+
sourceMap: sourcemaps,
152147
mangle: !!mangle,
153148
keep_classnames:
154149
!customConfig.mode || customConfig.mode === "production",

webpack/_helpers.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ function getRepoInfo() {
1616
}
1717
}
1818

19+
function getDevtool(sourcemaps, minimize) {
20+
if (!sourcemaps) return false
21+
return minimize ? "source-map" : "cheap-module-source-map"
22+
}
23+
1924
module.exports = {
2025
getRepoInfo,
26+
getDevtool,
2127
}

webpack/bundle.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const result = configBuilder(
2222
{
2323
minimize: true,
2424
mangle: true,
25-
sourcemaps: true,
25+
sourcemaps: false,
2626
includeDependencies: true,
2727
},
2828
{

webpack/es-bundle-core.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ const {
1414
WebpackBundleSizeAnalyzerPlugin,
1515
} = require("webpack-bundle-size-analyzer")
1616
const nodeExternals = require("webpack-node-externals")
17+
const { getDevtool } = require("./_helpers")
1718
// const { StatsWriterPlugin } = require("webpack-stats-plugin")
1819

1920
const minimize = true
@@ -44,7 +45,7 @@ const result = configBuilder(
4445
module: true,
4546
},
4647
},
47-
devtool: sourcemaps && minimize ? "source-map" : false,
48+
devtool: getDevtool(sourcemaps, minimize),
4849
externalsType: "module",
4950
externals: [
5051
{

webpack/es-bundle.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const result = configBuilder(
2121
{
2222
minimize: true,
2323
mangle: true,
24-
sourcemaps: true,
24+
sourcemaps: false,
2525
includeDependencies: true,
2626
},
2727
{

webpack/standalone.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const result = configBuilder(
88
{
99
minimize: true,
1010
mangle: true,
11-
sourcemaps: true,
11+
sourcemaps: false,
1212
},
1313
{
1414
entry: {

0 commit comments

Comments
 (0)