Skip to content

Commit 91b1bec

Browse files
authored
fix: label models section as Schemas in OpenAPI 3 (via #5065)
* fix: label models section `Schemas` in OpenAPI 3 * Update swos-63.js
1 parent b84a0fe commit 91b1bec

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/core/components/models.jsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export default class Models extends Component {
3737

3838
let showModels = layoutSelectors.isShown("models", defaultModelsExpandDepth > 0 && docExpansion !== "none")
3939
const specPathBase = this.getSchemaBasePath()
40+
const isOAS3 = specSelectors.isOAS3()
4041

4142
const ModelWrapper = getComponent("ModelWrapper")
4243
const Collapse = getComponent("Collapse")
@@ -45,7 +46,7 @@ export default class Models extends Component {
4546

4647
return <section className={ showModels ? "models is-open" : "models"}>
4748
<h4 onClick={() => layoutActions.show("models", !showModels)}>
48-
<span>Models</span>
49+
<span>{isOAS3 ? "Schemas" : "Models" }</span>
4950
<svg width="20" height="20">
5051
<use xlinkHref={showModels ? "#large-arrow-down" : "#large-arrow"} />
5152
</svg>
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
describe("SWOS-63: Schema/Model section labeling", () => {
2+
it("should render `Schemas` for OpenAPI 3", () => {
3+
cy
4+
.visit("/?url=/documents/petstore-expanded.openapi.yaml")
5+
.get("section.models > h4")
6+
.contains("Schemas")
7+
})
8+
it("should render `Models` for OpenAPI 2", () => {
9+
cy
10+
.visit("/?url=/documents/petstore.swagger.yaml")
11+
.get("section.models > h4")
12+
.contains("Models")
13+
})
14+
})

0 commit comments

Comments
 (0)