Skip to content

Commit c5c4e08

Browse files
authored
improve: nest Servers within Schemes container (via #4911)
* improve: nest Servers within Schemes container * linter fixes
1 parent 1690b31 commit c5c4e08

File tree

5 files changed

+21
-37
lines changed

5 files changed

+21
-37
lines changed

src/core/components/layouts/base.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,10 @@ export default class BaseLayout extends React.Component {
6060
</Col>
6161
</Row>
6262

63-
<SchemesContainer/>
63+
<SchemesContainer>
64+
<ServersContainer/>
65+
</SchemesContainer>
6466

65-
<ServersContainer/>
6667

6768
<FilterContainer/>
6869

src/core/containers/schemes.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ export default class SchemesContainer extends React.Component {
77
specActions: PropTypes.object.isRequired,
88
specSelectors: PropTypes.object.isRequired,
99
getComponent: PropTypes.func.isRequired,
10+
children: PropTypes.any
1011
}
1112

1213
render () {
@@ -24,6 +25,7 @@ export default class SchemesContainer extends React.Component {
2425
{schemes && schemes.size || securityDefinitions ? (
2526
<div className="scheme-container">
2627
<Col className="schemes wrapper" mobile={12}>
28+
{this.props.children}
2729
{schemes && schemes.size ? (
2830
<Schemes
2931
currentScheme={currentScheme}

src/core/plugins/oas3/components/servers-container.jsx

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -15,28 +15,19 @@ export default class ServersContainer extends React.Component {
1515

1616
const servers = specSelectors.servers()
1717

18-
const Col = getComponent("Col")
1918
const Servers = getComponent("Servers")
2019

21-
return (
20+
return servers && servers.size ? (
2221
<div>
23-
{servers && servers.size ? (
24-
<div className="global-server-container">
25-
<Col className="servers wrapper" mobile={12}>
26-
<span className="servers-title">Server</span>
27-
<Servers
28-
servers={servers}
29-
currentServer={oas3Selectors.selectedServer()}
30-
setSelectedServer={oas3Actions.setSelectedServer}
31-
setServerVariableValue={oas3Actions.setServerVariableValue}
32-
getServerVariable={oas3Selectors.serverVariableValue}
33-
getEffectiveServerValue={oas3Selectors.serverEffectiveValue}
34-
/>
35-
</Col>
36-
</div>
37-
38-
) : null}
39-
</div>
40-
)
22+
<span className="servers-title">Servers</span>
23+
<Servers
24+
servers={servers}
25+
currentServer={oas3Selectors.selectedServer()}
26+
setSelectedServer={oas3Actions.setSelectedServer}
27+
setServerVariableValue={oas3Actions.setServerVariableValue}
28+
getServerVariable={oas3Selectors.serverVariableValue}
29+
getEffectiveServerValue={oas3Selectors.serverEffectiveValue}
30+
/>
31+
</div> ) : null
4132
}
42-
}
33+
}

src/style/_layout.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,7 @@
667667
.schemes
668668
{
669669
display: flex;
670-
align-items: center;
670+
align-items: flex-end;
671671

672672
> label
673673
{

src/style/_servers.scss

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -53,19 +53,9 @@
5353
}
5454
}
5555

56-
57-
.global-server-container
58-
{
59-
margin: 0 0 20px 0;
60-
padding: 30px 0;
61-
62-
background: $server-container-background-color;
63-
box-shadow: 0 1px 2px 0 rgba($server-container-box-shadow-color,.15);
64-
65-
.servers-title {
66-
line-height: 2em;
67-
font-weight: bold;
68-
}
56+
.servers-title {
57+
font-size: 12px;
58+
font-weight: bold;
6959
}
7060

7161
.operation-servers {

0 commit comments

Comments
 (0)