Skip to content

Commit dc4e601

Browse files
authored
Merge branch 'master' into bug/3505-schema-title-in-array-schemes
2 parents 103aaa5 + 6af2aae commit dc4e601

File tree

15 files changed

+76
-56
lines changed

15 files changed

+76
-56
lines changed

dist/swagger-ui-bundle.js

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/swagger-ui-bundle.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/swagger-ui-standalone-preset.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/swagger-ui.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/swagger-ui.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/core/components/array-model.jsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export default class ArrayModel extends Component {
1515
}
1616

1717
render(){
18-
let { getComponent, required, schema, depth, expandDepth, name } = this.props
18+
let { getComponent, schema, depth, expandDepth, name } = this.props
1919
let items = schema.get("items")
2020
let title = schema.get("title") || name
2121
let properties = schema.filter( ( v, key) => ["type", "items", "$$ref"].indexOf(key) === -1 )
@@ -31,7 +31,7 @@ export default class ArrayModel extends Component {
3131
return <span className="model">
3232
<ModelCollapse title={titleEl} collapsed={ depth > expandDepth } collapsedContent="[...]">
3333
[
34-
<span><Model { ...this.props } schema={ items } required={ false }/></span>
34+
<span><Model { ...this.props } schema={ items } required={ false } depth={ depth + 1 } /></span>
3535
]
3636
{
3737
properties.size ? <span>
@@ -41,7 +41,6 @@ export default class ArrayModel extends Component {
4141
: null
4242
}
4343
</ModelCollapse>
44-
{ required && <span style={{ color: "red" }}>*</span>}
4544
</span>
4645
}
4746
}

src/core/components/object-model.jsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@ export default class ObjectModel extends Component {
1717
}
1818

1919
render(){
20-
let { schema, name, isRef, getComponent, depth, ...props } = this.props
21-
let { expandDepth, specSelectors } = this.props
20+
let { schema, name, isRef, getComponent, depth, expandDepth, specSelectors, ...props } = this.props
21+
let { isOAS3 } = specSelectors
22+
2223
let description = schema.get("description")
2324
let properties = schema.get("properties")
2425
let additionalProperties = schema.get("additionalProperties")
@@ -30,7 +31,10 @@ export default class ObjectModel extends Component {
3031
const Model = getComponent("Model")
3132
const ModelCollapse = getComponent("ModelCollapse")
3233

33-
const JumpToPathSection = ({ name }) => <span className="model-jump-to-path"><JumpToPath path={`definitions.${name}`} /></span>
34+
const JumpToPathSection = ({ name }) => {
35+
const path = isOAS3 && isOAS3() ? `components.schemas.${name}` : `definitions.${name}`
36+
return <span className="model-jump-to-path"><JumpToPath path={path} /></span>
37+
}
3438
const collapsedContent = (<span>
3539
<span>{ braceOpen }</span>...<span>{ braceClose }</span>
3640
{
@@ -55,7 +59,7 @@ export default class ObjectModel extends Component {
5559
}
5660
<span className="inner-object">
5761
{
58-
<table className="model" style={{ marginLeft: "2em" }}><tbody>
62+
<table className="model"><tbody>
5963
{
6064
!description ? null : <tr style={{ color: "#999", fontStyle: "italic" }}>
6165
<td>description:</td>

src/core/components/operation.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ export default class Operation extends PureComponent {
186186
}
187187
</div>
188188

189-
<Collapse isOpened={shown} animated>
189+
<Collapse isOpened={shown}>
190190
<div className="opblock-body">
191191
{ deprecated && <h4 className="opblock-title_normal"> Warning: Deprecated</h4>}
192192
{ description &&

src/core/components/parameter-row.jsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ export default class ParameterRow extends Component {
5858
render() {
5959
let {param, onChange, getComponent, isExecute, fn, onChangeConsumes, specSelectors, pathMethod} = this.props
6060

61+
let { isOAS3 } = specSelectors
62+
6163
// const onChangeWrapper = (value) => onChange(param, value)
6264
const JsonSchemaForm = getComponent("JsonSchemaForm")
6365
const ParamBody = getComponent("ParamBody")
@@ -95,6 +97,9 @@ export default class ParameterRow extends Component {
9597
{ !required ? null : <span style={{color: "red"}}>&nbsp;*</span> }
9698
</div>
9799
<div className="parameter__type">{ param.get("type") } { itemType && `[${itemType}]` }</div>
100+
<div className="parameter__deprecated">
101+
{ isOAS3 && isOAS3() && param.get("deprecated") ? "deprecated": null }
102+
</div>
98103
<div className="parameter__in">({ param.get("in") })</div>
99104
</td>
100105

src/core/components/primitive-model.jsx

Lines changed: 28 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@ export default class Primitive extends Component {
77
static propTypes = {
88
schema: PropTypes.object.isRequired,
99
getComponent: PropTypes.func.isRequired,
10-
required: PropTypes.bool
10+
name: PropTypes.string,
11+
depth: PropTypes.number
1112
}
1213

1314
render(){
14-
let { schema, getComponent, required } = this.props
15+
let { schema, getComponent, name, depth } = this.props
1516

1617
if(!schema || !schema.get) {
1718
// don't render if schema isn't correctly formed
@@ -24,32 +25,34 @@ export default class Primitive extends Component {
2425
let enumArray = schema.get("enum")
2526
let description = schema.get("description")
2627
let properties = schema.filter( ( v, key) => ["enum", "type", "format", "description", "$$ref"].indexOf(key) === -1 )
27-
let style = required ? { fontWeight: "bold" } : {}
2828
const Markdown = getComponent("Markdown")
2929
const EnumModel = getComponent("EnumModel")
3030

31-
return <span className="prop">
32-
<span className="prop-type" style={ style }>{ type }</span> { required && <span style={{ color: "red" }}>*</span>}
33-
{ format && <span className="prop-format">(${format})</span>}
34-
{
35-
properties.size ? properties.entrySeq().map( ( [ key, v ] ) => <span key={`${key}-${v}`} style={ propStyle }>
36-
<br />{ key }: { String(v) }</span>)
37-
: null
38-
}
39-
{
40-
!description ? null :
41-
<Markdown source={ description } />
42-
}
43-
{
44-
xml && xml.size ? (<span><br /><span style={ propStyle }>xml:</span>
45-
{
46-
xml.entrySeq().map( ( [ key, v ] ) => <span key={`${key}-${v}`} style={ propStyle }><br/>&nbsp;&nbsp;&nbsp;{key}: { String(v) }</span>).toArray()
47-
}
48-
</span>): null
49-
}
50-
{
51-
enumArray && <EnumModel value={ enumArray } getComponent={ getComponent } />
52-
}
31+
return <span className="model">
32+
<span className="prop">
33+
{ name && <span className={`${depth === 1 && "model-title"} prop-name`}>{ name }</span> }
34+
<span className="prop-type">{ type }</span>
35+
{ format && <span className="prop-format">(${format})</span>}
36+
{
37+
properties.size ? properties.entrySeq().map( ( [ key, v ] ) => <span key={`${key}-${v}`} style={ propStyle }>
38+
<br />{ key }: { String(v) }</span>)
39+
: null
40+
}
41+
{
42+
!description ? null :
43+
<Markdown source={ description } />
44+
}
45+
{
46+
xml && xml.size ? (<span><br /><span style={ propStyle }>xml:</span>
47+
{
48+
xml.entrySeq().map( ( [ key, v ] ) => <span key={`${key}-${v}`} style={ propStyle }><br/>&nbsp;&nbsp;&nbsp;{key}: { String(v) }</span>).toArray()
49+
}
50+
</span>): null
51+
}
52+
{
53+
enumArray && <EnumModel value={ enumArray } getComponent={ getComponent } />
54+
}
55+
</span>
5356
</span>
5457
}
5558
}

0 commit comments

Comments
 (0)