Skip to content

Commit dbaf19e

Browse files
committed
make value prop mandatory on LakeSelect
1 parent 19f710b commit dbaf19e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/lake/__stories__/Select.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ const items = [
5757
const EditableSelect = ({
5858
initialValue,
5959
...props
60-
}: Except<SelectProps<number>, "value" | "onValueChange" | "items"> & {
60+
}: Except<SelectProps<number | undefined>, "value" | "onValueChange" | "items"> & {
6161
initialValue?: number;
6262
}) => {
6363
const [value, setValue] = useState(initialValue);

packages/lake/src/components/LakeSelect.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ export type SelectProps<V, T extends Item<V> = Item<V>> = {
147147
icon?: IconName;
148148
color?: ColorVariants;
149149
disabled?: boolean;
150-
value?: V;
150+
value: V;
151151
onValueChange: (value: V) => void;
152152
disabledItems?: { value: V; message?: string }[];
153153
renderItem?: (item: T, isSelected: boolean) => ReactElement;

0 commit comments

Comments
 (0)