Skip to content

Commit 6bbe5c2

Browse files
authored
fix(register): node18 compatible issues (#814)
1 parent 0be008e commit 6bbe5c2

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

.github/workflows/CI.yml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ jobs:
1515
fail-fast: false
1616
matrix:
1717
os: [ubuntu-latest, macos-latest, windows-latest]
18+
node: [18, 20, 22]
1819

19-
name: stable - ${{ matrix.os }} - node@20
20+
name: stable - ${{ matrix.os }} - node@${{ matrix.node }}
2021
runs-on: ${{ matrix.os }}
2122

2223
steps:
@@ -27,7 +28,7 @@ jobs:
2728
- name: Setup node
2829
uses: actions/setup-node@v4
2930
with:
30-
node-version: 20
31+
node-version: ${{ matrix.node }}
3132
cache: 'pnpm'
3233

3334
- name: 'Install dependencies'
@@ -55,18 +56,13 @@ jobs:
5556
steps:
5657
- uses: actions/checkout@v4
5758

59+
- uses: pnpm/action-setup@v4
60+
5861
- name: Setup node
5962
uses: actions/setup-node@v4
6063
with:
6164
node-version: 20
62-
63-
- name: Cache NPM dependencies
64-
uses: actions/cache@v4
65-
with:
66-
path: ~/.pnpm-store
67-
key: npm-cache-ubuntu-latest-node@20
68-
69-
- uses: pnpm/action-setup@v4
65+
cache: 'pnpm'
7066

7167
- name: 'Install dependencies'
7268
run: pnpm install

packages/register/esm.mts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,14 @@ export const load: LoadHook = async (url, context, nextLoad) => {
279279

280280
const { source, format: resolvedFormat } = await nextLoad(url, context)
281281

282+
if (!source) {
283+
debug('No source', url, resolvedFormat)
284+
return {
285+
source,
286+
format: resolvedFormat,
287+
}
288+
}
289+
282290
debug('loaded', url, resolvedFormat)
283291

284292
const code = !source || typeof source === 'string' ? source : Buffer.from(source).toString()

0 commit comments

Comments
 (0)