fix: clippy warnings

Author: reneleonhardt

crates/hstr/src/lib.rs

@@ -181,7 +181,7 @@ impl<'de> serde::de::Deserialize<'de> for Atom {
 }
 const DYNAMIC_TAG: u8 = 0b_00;
 const INLINE_TAG: u8 = 0b_01; // len in upper nybble
-const INLINE_TAG_INIT: NonZeroU8 = unsafe { NonZeroU8::new_unchecked(INLINE_TAG) };
+const INLINE_TAG_INIT: NonZeroU8 = NonZeroU8::new(INLINE_TAG).unwrap();
 const TAG_MASK: u8 = 0b_11;
 const LEN_OFFSET: usize = 4;
 const LEN_MASK: u8 = 0xf0;

crates/preset_env_base/src/version.rs

@@ -179,7 +179,7 @@ pub fn should_enable(target: &Versions, feature: &Versions, default: bool) -> bo
                         _ => None,
                     });
 
-                feature_or_fallback_version.map_or(true, |v| v > target_version)
+                feature_or_fallback_version.is_none_or(|v| v > target_version)
             })
         },
     )

crates/swc_bundler/src/modules/sort/graph.rs

@@ -1,4 +1,4 @@
-use std::{collections::VecDeque, iter::repeat};
+use std::collections::VecDeque;
 
 use petgraph::{
     prelude::GraphMap,
@@ -68,7 +68,7 @@ impl StmtDepGraph {
     fn insert_transitives(&mut self, from: usize, to: usize) {
         if self.paths.len() <= from {
             self.paths
-                .extend(repeat(Default::default()).take(from + 1 - self.paths.len()))
+                .extend(std::iter::repeat_n(Default::default(), from + 1 - self.paths.len()))
         }
         if !self.paths[from].insert(to) {
             return;

crates/swc_css_ast/src/token.rs

@@ -170,7 +170,7 @@ impl Take for Token {
 }
 
 #[allow(clippy::derived_hash_with_manual_eq)]
-#[allow(clippy::transmute_float_to_int)]
+#[allow(unnecessary_transmutes)]
 impl Hash for Token {
     fn hash<H: Hasher>(&self, state: &mut H) {
         fn integer_decode(val: f64) -> (u64, i16, i8) {

crates/swc_css_ast/src/value.rs

@@ -352,7 +352,7 @@ pub struct Number {
 impl Eq for Number {}
 
 #[allow(clippy::derived_hash_with_manual_eq)]
-#[allow(clippy::transmute_float_to_int)]
+#[allow(unnecessary_transmutes)]
 impl Hash for Number {
     fn hash<H: Hasher>(&self, state: &mut H) {
         fn integer_decode(val: f64) -> (u64, i16, i8) {

crates/swc_ecma_ast/src/lit.rs

@@ -410,7 +410,7 @@ impl EqIgnoreSpan for Number {
 }
 
 #[allow(clippy::derived_hash_with_manual_eq)]
-#[allow(clippy::transmute_float_to_int)]
+#[allow(unnecessary_transmutes)]
 impl Hash for Number {
     fn hash<H: Hasher>(&self, state: &mut H) {
         fn integer_decode(val: f64) -> (u64, i16, i8) {

crates/swc_ecma_codegen/src/lib.rs

@@ -1376,7 +1376,7 @@ fn require_space_before_rhs(rhs: &Expr, op: &BinaryOp) -> bool {
 }
 
 fn is_empty_comments(span: &Span, comments: &Option<&dyn Comments>) -> bool {
-    span.is_dummy() || comments.map_or(true, |c| !c.has_leading(span.span_hi() - BytePos(1)))
+    span.is_dummy() || comments.is_none_or(|c| !c.has_leading(span.span_hi() - BytePos(1)))
 }
 
 fn span_has_leading_comment(cmt: &dyn Comments, span: Span) -> bool {

crates/swc_ecma_lexer/src/lexer/state.rs

@@ -149,7 +149,7 @@ impl State {
         } else if next.is_rparen() || next.is_rbrace() {
             // TODO: Verify
             if context.len() == 1 {
-                return true;
+                true
             } else {
                 let out = context.pop().unwrap();
                 // let a = function(){}

crates/swc_ecma_minifier/src/compress/optimize/inline.rs

@@ -296,7 +296,7 @@ impl Optimizer<'_> {
                             || usage.flags.contains(VarUsageInfoFlags::USED_AS_ARG)
                                 && ref_count > 1
                             || ref_count > usage.callee_count
-                            || !is_arrow_simple_enough_for_copy(arr).is_some_and(|cost| cost <= 8))
+                            || is_arrow_simple_enough_for_copy(arr).is_none_or(|cost| cost > 8))
                     }
                     _ => false,
                 }

crates/swc_ecma_regexp/src/parser/reader/string_literal_parser/parser_impl.rs

@@ -213,7 +213,7 @@ impl Parser {
         if let Some(cp) = self.parse_character_escape_sequence() {
             return Ok(Some(cp));
         }
-        if self.peek() == Some('0') && self.peek2().map_or(true, |ch| !ch.is_ascii_digit()) {
+        if self.peek() == Some('0') && self.peek2().is_none_or(|ch| !ch.is_ascii_digit()) {
             self.advance();
             return Ok(Some(0x00));
         }