Skip to content

Commit c19c252

Browse files
author
Greg Wilson
committed
Merge pull request #275 from mikej888/motivation-fix
Removed lingering references to motivation.md and motivation.html
2 parents 44d86dc + d1bab6f commit c19c252

File tree

3 files changed

+0
-34
lines changed

3 files changed

+0
-34
lines changed

Makefile

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,6 @@ clean :
4444
## preview : Build website locally for checking.
4545
preview : $(DST_ALL)
4646

47-
# Pattern for slides (different parameters and template).
48-
motivation.html : motivation.md _layouts/slides.revealjs Makefile
49-
${PANDOC} -s -t revealjs --slide-level 2 \
50-
${PANDOC_FLAGS} \
51-
--template=_layouts/slides \
52-
-o $@ $<
53-
5447
# Pattern to build a generic page.
5548
%.html : %.md _layouts/page.html $(FILTERS)
5649
${PANDOC} -s -t html \

tools/check.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -542,16 +542,6 @@ def _run_tests(self):
542542
return all(tests) and parent_tests
543543

544544

545-
class MotivationPageValidator(MarkdownValidator):
546-
"""Validate motivation.md"""
547-
WARN_ON_EXTRA_HEADINGS = False
548-
549-
DOC_HEADERS = {"layout": vh.is_str,
550-
"title": vh.is_str,
551-
"subtitle": vh.is_str}
552-
# TODO: How to validate? May be a mix of reveal.js (HTML) + markdown.
553-
554-
555545
class ReferencePageValidator(MarkdownValidator):
556546
"""Validate reference.md"""
557547
HEADINGS = ["Glossary"]
@@ -678,7 +668,6 @@ class DiscussionPageValidator(MarkdownValidator):
678668
# Dict of {name: (Validator, filename_pattern)}
679669
LESSON_TEMPLATES = {"index": (IndexPageValidator, "^index"),
680670
"topic": (TopicPageValidator, "^[0-9]{2}-.*"),
681-
"motivation": (MotivationPageValidator, "^motivation"),
682671
"reference": (ReferencePageValidator, "^reference"),
683672
"instructor": (InstructorPageValidator, "^instructors"),
684673
"license": (LicensePageValidator, "^LICENSE"),
@@ -786,7 +775,6 @@ def check_required_files(dir_to_validate):
786775
"index.md",
787776
"instructors.md",
788777
"LICENSE.md",
789-
"motivation.md",
790778
"README.md",
791779
"reference.md"]
792780
valid = True

tools/test_check.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ def test_index_has_valid_section_headings(self):
9999
100100
## Other Resources
101101
102-
* [Motivation](motivation.html)
103102
* [Reference Guide](reference.html)
104103
* [Next Steps](discussion.html)
105104
* [Instructor's Guide](instructors.html)""")
@@ -114,7 +113,6 @@ def test_index_fail_when_section_heading_absent(self):
114113
115114
## Other Resources
116115
117-
* [Motivation](motivation.html)
118116
* [Reference Guide](reference.html)
119117
* [Next Steps](discussion.html)
120118
* [Instructor's Guide](instructors.html)""")
@@ -141,7 +139,6 @@ def test_fail_when_section_heading_is_wrong_level(self):
141139
142140
## Other Resources
143141
144-
* [Motivation](motivation.html)
145142
* [Reference Guide](reference.html)
146143
* [Next Steps](discussion.html)
147144
* [Instructor's Guide](instructors.html)""")
@@ -161,7 +158,6 @@ def test_fail_when_section_headings_in_wrong_order(self):
161158
162159
## Other Resources
163160
164-
* [Motivation](motivation.html)
165161
* [Reference Guide](reference.html)
166162
* [Instructor's Guide](instructors.html)
167163
@@ -444,17 +440,6 @@ def test_sample_file_passes_validation(self):
444440
self.assertTrue(res)
445441

446442

447-
class TestMotivationPage(BaseTemplateTest):
448-
"""Verifies that the instructors page validator works as expected"""
449-
SAMPLE_FILE = os.path.join(MARKDOWN_DIR, "motivation.md")
450-
VALIDATOR = check.MotivationPageValidator
451-
452-
def test_sample_file_passes_validation(self):
453-
sample_validator = self.VALIDATOR(self.SAMPLE_FILE)
454-
res = sample_validator.validate()
455-
self.assertTrue(res)
456-
457-
458443
class TestReferencePage(BaseTemplateTest):
459444
"""Verifies that the reference page validator works as expected"""
460445
SAMPLE_FILE = os.path.join(MARKDOWN_DIR, "reference.md")

0 commit comments

Comments
 (0)