Add Dbus to allow Shairport-Sync to run #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds dbus to the container, behind a new env var flag. This allows shairport-sync to correctly start and work. Note that Avahi doesn't seem to be required - shairport-sync complains about it being missing on startup, but this doesn't effect functionality.
Sjoerd82
approved these changes
Mar 4, 2025
Owner
|
Thanks a lot @Adam-Ant that looks promising. It would be great if you could double-check that it's working after I merged, as i|m lacking devices from the apple ecosystem. Best, me|kor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based heavily on the work of @smplman in #6, but as that PR seems to have gone quiet I thought I'd pick it up.
This adds dbus to the container, gated behind a
START_AIRPLAYenv flag as requested.It seems that dbus is all that was required for shairpoint-sync to start - it now works for me out of the box with the default airplay source in the snapserver config. Shairport does log a few warnings about Avahi being missing, but these don't effect functionality.
Closes #3