adding dbus and avahi to enable shairport-sync to work correctly #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@sweisgerber can you take a look at this when you get a chance. |
Owner
|
Yeah, I will have a look, thanks for the submission. |
Owner
|
Hey there, did you manage to successfully start this image? Building with: running with: version: "3"
services:
snapcast:
image: local/docker-snapcast:latest
hostname: snapcast-local
environment:
- PUID=1000
- PGID=1000 # set to audio group ID
- TZ=Europe/Berlin
- START_SNAPCLIENT=false # set to `true` for snapclient to start
# --host: name or ip of compose service or dockerhost
# --soundcard: <ID> from `snapclient -l` from inside the container
# - SNAPCLIENT_OPTS=--host snapcast --soundcard <ID>
# => Don't use quotes for SNAPCLIENT_OPTS="" !
# - HOST_AUDIO_GROUP=<AUDIO-GID> # set to GID of host audio group
restart: "unless-stopped"
ports:
- 1704:1704 # port for the actual audio streaming
- 1705:1705 # port for TCP Json RPC
- 1780:1780 # port for the SnapWeb Webinterface
# devices:
# - /dev/snd:/dev/snd # optional, only if you want to use snapclient
volumes:
- /srv/snapcast/config/:/config/
- /srv/snapcast/data/:/data/
# /audio should get used to place FIFOs for audio playback from mpd/mopidy/host/etc
- /srv/audio-fifos/:/audio/
Unchanged commit c0ae760 |
Author
|
Thanks for taking a look @sweisgerber. Here is my and here is how I'm building Then running Here are the docker logs Here is my I am able to cast Spotify from phone to my laptop via AirPlay. |
|
Running into the same airplay issue as this PR is attempting to fix. Can the PR be merged to fix it or is there still an outstanding issue to be solved? |
Owner
|
Hello, sure that avahi is even needed? $ sudo docker ps 10:00:20
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
1bd6af5dd431 docker-snapcast-pr-snapcast "/init" 15 seconds ago Up 15 seconds docker-snapcast-pr-snapcast-1
#
$ sudo docker compose exec snapcast sh
root@falcon:/# ps ax | grep -i avahi
38 ? S 0:00 s6-supervise svc-avahi
181 pts/0 S+ 0:00 grep -i avahi
# In contrast, d-bus works fine: I used your compose from above 1:1 I noticed it, because I restructured the s6 run files a little, that dbus & avahi are no hard-dependency for snapserver anymore and one can hide their start-up behind a feature flag. The feature-flag dependent start-up from my side is ready and I will push it soonish. Could you please test if avahi starts for you inside the container and report back? I'm unable to test airplay support at home. |
|
Any progress here? Or how does the clients find the server without? |
Owner
|
Not really, as I don't have time or devices to test the setup. |
|
Hi, though not a great fan, I don't think Avahi is bloat. Unfortunatly I ran across some hardware that only supports Snapcast over mDNS (I have opinions on this...), no hardcoded IP possible, so I for one would really like to see this included. |
Owner
|
With #16, we have d-bus available, |
…into smplman/shairport-sync
Author
|
@Sjoerd82 sorry for the delay. I have updated this PR to mimic what @Adam-Ant did for CC @sweisgerber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR came about to fix #3. It modifies the
Dockerfileto add thedbusapk along with service startups for bothdbusandavahi. I was going to add an ENV var to be able to toggle these features, but ran into issues makingdbusandavahioptional dependencies ofsvc-snapserver.Any suggestions or feedback are welcome.