Namespace ambiguity with TimeoutError has to be resolved in a strange way

[gregcotten]

In a situation where you import both FlyingSocks and Timeout

import FlyingSocks
import Timeout

and try to do something like

do {
    for try await message in socket.messages.timeout(seconds: 30) {}
} catch where error is TimeoutError {}

You get an error from the Swift compiler:
'TimeoutError' is ambiguous for type lookup in this context

Turns out FlyingSocks has its own (perhaps lagged-behind copy of) swift-timeout.

You might think you could resolve it by simply getting more specific by changing the catch to

catch where error is Timeout.TimeoutError {}

But since there is a struct named Timeout inside the package Timeout, you get another error, since it's confusing the struct and the name of the package:
'TimeoutError' is not a member type of struct 'Timeout.Timeout'

The only way to get Swift to build without error is to explicitly import the TimeoutError struct:

import FlyingSocks
import Timeout
import struct Timeout.TimeoutError

and change the line back to

catch where error is TimeoutError {}

I think the only fix I can think of involves changing the name of the (unfortunately public) struct Timeout to something that isn't the name of the package, perhaps TimeoutState, or something similar?

[swhitty]

Ah I've seen this old problem before because I keep naming this way 🤦

I think renmaing the struct Timeout to something else is fine. Maybe TimeoutController?

Additionally I think the FlyingFox TimeoutError should not be public but maybe instead be a SocketError 🤔

[swhitty]

It has been renamed on main to TimeoutController #7

And on the main branch of FlyingFox, TimeoutError has been replaced with SocketError.timeout swhitty/FlyingFox#159

Let me know if this resolves it

[gregcotten]

It has been renamed on main to TimeoutController #7

And on the main branch of FlyingFox, TimeoutError has been replaced with SocketError.timeout swhitty/FlyingFox#159

Let me know if this resolves it

sure does! might be worth a new tag.

EDIT: So sorry, no it's the same problem - now it references the typealias if I try to disambiguate with Timeout.TimeoutError... Of course updating FlyingFox will prevent me from needing to disambiguate, but the source problem remains.

[swhitty]

Ok i can remove the alias

[swhitty]

0.3.1 removes the typealias