Skip to content

Commit dea3ae0

Browse files
authored
Merge pull request #333 from sidepelican/versioncheck
Fix error output on Linux
2 parents a94947b + 85dfe5b commit dea3ae0

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

__tests__/get-version.test.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,11 @@ Target: x86_64-apple-macosx11.0`
2222
);
2323
expect(version).toBe("5.5");
2424
});
25+
26+
it("identifies version from swift version on linux", async () => {
27+
const version = versionFromString(
28+
"Swift version 5.5.1 (swift-5.5.1-RELEASE)"
29+
);
30+
expect(version).toBe("5.5.1");
31+
});
2532
});

dist/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2751,7 +2751,7 @@ function run() {
27512751
core.setOutput("version", version);
27522752
}
27532753
else {
2754-
core.error("Failed to setup requested swift version");
2754+
core.error(`Failed to setup requested swift version. requestd: ${version}, actual: ${current}`);
27552755
}
27562756
}
27572757
catch (error) {
@@ -13725,7 +13725,7 @@ function getVersion(command = "swift", args = ["--version"]) {
1372513725
}
1372613726
exports.getVersion = getVersion;
1372713727
function versionFromString(subject) {
13728-
const match = subject.match(/Apple\ Swift\ version (?<version>[0-9]+\.[0-9+]+(\.[0-9]+)?)/) || {
13728+
const match = subject.match(/Swift\ version (?<version>[0-9]+\.[0-9+]+(\.[0-9]+)?)/) || {
1372913729
groups: { version: null },
1373013730
};
1373113731
if (!match.groups || !match.groups.version) {

src/get-version.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export async function getVersion(
2929

3030
export function versionFromString(subject: string): string | null {
3131
const match = subject.match(
32-
/Apple\ Swift\ version (?<version>[0-9]+\.[0-9+]+(\.[0-9]+)?)/
32+
/Swift\ version (?<version>[0-9]+\.[0-9+]+(\.[0-9]+)?)/
3333
) || {
3434
groups: { version: null },
3535
};

src/main.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ async function run() {
2626
if (current === version) {
2727
core.setOutput("version", version);
2828
} else {
29-
core.error("Failed to setup requested swift version");
29+
core.error(
30+
`Failed to setup requested swift version. requestd: ${version}, actual: ${current}`
31+
);
3032
}
3133
} catch (error) {
3234
let dump: String;

0 commit comments

Comments
 (0)