Skip to content

Commit 10db0ef

Browse files
committed
1 parent 889fbc3 commit 10db0ef

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

.github/workflows/pull_request.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ jobs:
8888
# when building in a Docker container, we don't have a host toolchain
8989
# locally, but we need one in order to run the SDK validation tests
9090
source ./scripts/toolchain-vars.sh
91+
export SWIFT_TOOLCHAIN_URL=${SWIFT_TOOLCHAIN_URL}
9192
mkdir -p ${{ runner.temp }}/swift-android-sdk/host-toolchain
9293
./scripts/install-swift.sh ${{ runner.temp }}/swift-android-sdk/host-toolchain/swift
9394
${{ runner.temp }}/swift-android-sdk/host-toolchain/swift/bin/swift --version
@@ -96,9 +97,6 @@ jobs:
9697
shell: bash
9798
run: |
9899
set -ex
99-
ls -la ${{ runner.temp }}
100-
ls -la ${{ runner.temp }}/swift-android-sdk
101-
ls -la ${{ runner.temp }}/swift-android-sdk/products
102100
SWIFT_ROOT=$(dirname ${{ runner.temp }}/swift-android-sdk/host-toolchain/*/usr)
103101
echo "swift-root=${SWIFT_ROOT}" >> $GITHUB_OUTPUT
104102
echo "swift-path=${SWIFT_ROOT}/usr/bin/swift" >> $GITHUB_OUTPUT
@@ -143,7 +141,7 @@ jobs:
143141
${{ steps.info.outputs.swift-path }} sdk install ${{ steps.info.outputs.artifact-path }}
144142
${{ steps.info.outputs.swift-path }} sdk configure --show-configuration $(${{ steps.info.outputs.swift-path }} sdk list | head -n 1) ${{ steps.info.outputs.sdk-id }}
145143
# recent releases require that ANDROID_NDK_ROOT *not* be set
146-
# see https://github.com/finagolfin/swift-android-sdk/issues/207
144+
# see https://github.com/swiftlang/swift-driver/pull/1879
147145
echo "ANDROID_NDK_ROOT=" >> $GITHUB_ENV
148146
149147
- name: Create Demo Project

swift-ci/sdks/android/README.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,19 @@
1-
# Build scripts for Swift Android SDK
1+
# Dockerfile-based build for Swift Android SDK
2+
3+
This is a Dockerfile-based build set-up for the Swift Android SDK.
4+
5+
To build the Docker container and run the
6+
7+
```
8+
$ docker build -t swift-android .
9+
```
210

311
This folder contains scripts to build a Swift Android SDK
412
in the form of an artifactbundle.
513

614
## Running
715

8-
The top-level `./build` script installs a host toolchain and the
16+
The top-level `./build-docker` script installs a host toolchain and the
917
Android NDK, and then invokes `scripts/fetch-source.sh` which will
1018
fetch tagged sources for libxml2, curl, boringssl, and swift.
1119

@@ -27,7 +35,7 @@ whereas building for all the architectures takes over an hour.
2735
To build an artifactbundle for just the `x86_64` architecture, run:
2836

2937
```
30-
TARGET_ARCHS=x86_64 ./build
38+
TARGET_ARCHS=aarch64 ./build-docker
3139
```
3240

3341
## Installing and validating the SDK

0 commit comments

Comments
 (0)