Skip to content

Commit 1281724

Browse files
committed
Make RedisCommandHandler final
Motivation: During SSWG review, feedback was provided that forced a re-evaluation of early design feedback interpretation on composability of RedisNIO. First understanding was that the desire was to have "customization points" to gain benefits of implementation of RedisCommandHandler, while new understanding is that it just needs to be public in order for users to include it in their own custom ChannelPipeline schemes. Modifications: `RedisCommandHandler` is now a final class. Result: Users will no longer be able to subclass `RedisCommandHandler`, but gain a super slight performance increase. This contributes to #47.
1 parent cc47773 commit 1281724

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Sources/RedisNIO/ChannelHandlers/RedisCommandHandler.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public struct RedisCommandContext {
3030
}
3131

3232
/// A `ChannelDuplexHandler` that works with `RedisCommandContext`s to send commands and forward responses.
33-
open class RedisCommandHandler {
33+
public final class RedisCommandHandler {
3434
/// Queue of promises waiting to receive a response value from a sent command.
3535
private var commandResponseQueue: CircularBuffer<EventLoopPromise<RESPValue>>
3636
private var logger: Logger

0 commit comments

Comments
 (0)