Rename RedisData.basicString to .simpleString to be consistent throughout code and Redis RESP protocol names

Author: Mordil

Sources/NIORedis/Coders/RedisDataDecoder.swift

@@ -52,7 +52,7 @@ extension RedisDataDecoder {
         switch token {
         case .plus:
             guard let string = try _parseSimpleString(at: &position, from: &buffer) else { return .notYetParsed }
-            return .parsed(.basicString(string))
+            return .parsed(.simpleString(string))
 
         case .colon:
             guard let number = try _parseInteger(at: &position, from: &buffer) else { return .notYetParsed }
@@ -135,7 +135,7 @@ extension RedisDataDecoder {
             // since size = 0, and we successfully parsed the size
             // the beginning of the next message should be 2 further (the final \r\n - $0\r\n\r\n)
             position += 2
-            return .parsed(.bulkString("".convertedToData()))
+            return .parsed(.bulkString(Data()))
         }
 
         // verify that we have at least our expected bulk string message

Sources/NIORedis/Data/RedisData.swift

@@ -5,7 +5,7 @@ import Foundation
 /// See: https://redis.io/topics/protocol
 public enum RedisData {
     case null
-    case basicString(String)
+    case simpleString(String)
     case bulkString(Data)
     case error(RedisError)
     case integer(Int)
@@ -46,7 +46,7 @@ extension RedisData {
     /// Extracts the basic/bulk string as a `String`.
     var string: String? {
         switch self {
-        case .basicString(let string): return string
+        case .simpleString(let string): return string
         case .bulkString(let data): return String(bytes: data, encoding: .utf8)
         default: return nil
         }