Simplify RedisCommandExecutor and RedisConnection

Motivation:

`RedisCommandExecutor` was a complex and "wordy" name that was not 100% clear as to how it relates to other types.

`RedisConnection` also has not had a strong use case shown for it to exists as a separate protocol - using up a great name for the "out of the box" implementation.

Result:

`RedisClient` instead of `RedisCommandExecutor` is more clear as to what it is, in Redis terminology, a communication client.

`RedisConnection` as a concrete class provides an identifiable basic block for making connections to Redis.

`RedisConnection` also saw some fixes to `close()` while having some names and comment blocks tweaked for updated naming.

Author: Mordil

Sources/NIORedis/Commands/BasicCommands.swift

@@ -1,7 +1,7 @@
 import Foundation
 import NIO
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Echos the provided message through the Redis instance.
     ///
     /// See [https://redis.io/commands/echo](https://redis.io/commands/echo)
@@ -95,7 +95,7 @@ extension RedisCommandExecutor {
 
 // MARK: Scan
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Incrementally iterates over all keys in the currently selected database.
     ///
     /// [https://redis.io/commands/scan](https://redis.io/commands/scan)

Sources/NIORedis/Commands/HashCommands.swift

@@ -2,7 +2,7 @@ import NIO
 
 // MARK: Static Helpers
 
-extension RedisCommandExecutor {
+extension RedisClient {
     @usableFromInline
     static func _mapHashResponse(_ values: [String]) -> [String: String] {
         guard values.count > 0 else { return [:] }
@@ -23,7 +23,7 @@ extension RedisCommandExecutor {
 
 // MARK: General
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Removes the specified fields from a hash.
     ///
     /// See [https://redis.io/commands/hdel](https://redis.io/commands/hdel)
@@ -125,7 +125,7 @@ extension RedisCommandExecutor {
 
 // MARK: Set
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Sets a hash field to the value specified.
     /// - Note: If you do not want to overwrite existing values, use `hsetnx(_:field:to:)`.
     ///
@@ -192,7 +192,7 @@ extension RedisCommandExecutor {
 
 // MARK: Get
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Gets a hash field's value.
     ///
     /// See [https://redis.io/commands/hget](https://redis.io/commands/hget)
@@ -237,7 +237,7 @@ extension RedisCommandExecutor {
 
 // MARK: Increment
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Increments a hash field's value and returns the new value.
     ///
     /// See [https://redis.io/commands/hincrby](https://redis.io/commands/hincrby)

Sources/NIORedis/Commands/ListCommands.swift

@@ -2,7 +2,7 @@ import NIO
 
 // MARK: General
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Gets the length of a list.
     ///
     /// See [https://redis.io/commands/llen](https://redis.io/commands/llen)
@@ -107,7 +107,7 @@ extension RedisCommandExecutor {
 
 // MARK: Insert
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Inserts the element before the first element matching the "pivot" value specified.
     ///
     /// See [https://redis.io/commands/linsert](https://redis.io/commands/linsert)
@@ -152,7 +152,7 @@ extension RedisCommandExecutor {
 
 // MARK: Head Operations
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Removes the first element of a list.
     ///
     /// See [https://redis.io/commands/lpop](https://redis.io/commands/lpop)
@@ -196,7 +196,7 @@ extension RedisCommandExecutor {
 
 // MARK: Tail Operations
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Removes the last element a list.
     ///
     /// See [https://redis.io/commands/rpop](https://redis.io/commands/rpop)

Sources/NIORedis/Commands/SetCommands.swift

@@ -3,7 +3,7 @@ import NIO
 
 // MARK: General
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Gets all of the elements contained in a set.
     /// - Note: Ordering of results are stable between multiple calls of this method to the same set.
     ///
@@ -152,7 +152,7 @@ extension RedisCommandExecutor {
 
 // MARK: Diff
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Calculates the difference between two or more sets.
     ///
     /// See [https://redis.io/commands/sdiff](https://redis.io/commands/sdiff)
@@ -185,7 +185,7 @@ extension RedisCommandExecutor {
 
 // MARK: Intersect
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Calculates the intersection of two or more sets.
     ///
     /// See [https://redis.io/commands/sinter](https://redis.io/commands/sinter)
@@ -218,7 +218,7 @@ extension RedisCommandExecutor {
 
 // MARK: Union
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Calculates the union of two or more sets.
     ///
     /// See [https://redis.io/commands/sunion](https://redis.io/commands/sunion)

Sources/NIORedis/Commands/SortedSetCommands.swift

@@ -2,7 +2,7 @@ import NIO
 
 // MARK: Static Helpers
 
-extension RedisCommandExecutor {
+extension RedisClient {
     @usableFromInline
     static func _mapSortedSetResponse(
         _ response: [RESPValue],
@@ -32,7 +32,7 @@ extension RedisCommandExecutor {
 
 // MARK: General
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Adds elements to a sorted set, assigning their score to the values provided.
     ///
     /// See [https://redis.io/commands/zadd](https://redis.io/commands/zadd)
@@ -140,7 +140,7 @@ extension RedisCommandExecutor {
 
 // MARK: Rank
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Returns the rank (index) of the specified element in a sorted set.
     /// - Note: This treats the ordered set as ordered from low to high.
     /// For the inverse, see `zrevrank(of:in:)`.
@@ -174,7 +174,7 @@ extension RedisCommandExecutor {
 
 // MARK: Count
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Returns the number of elements in a sorted set with a score within the range specified.
     ///
     /// See [https://redis.io/commands/zcount](https://redis.io/commands/zcount)
@@ -211,7 +211,7 @@ extension RedisCommandExecutor {
 
 // MARK: Pop
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Removes elements from a sorted set with the lowest scores.
     ///
     /// See [https://redis.io/commands/zpopmin](https://redis.io/commands/zpopmin)
@@ -280,7 +280,7 @@ extension RedisCommandExecutor {
 
 // MARK: Increment
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Increments the score of the specified element in a sorted set.
     ///
     /// See [https://redis.io/commands/zincrby](https://redis.io/commands/zincrby)
@@ -302,7 +302,7 @@ extension RedisCommandExecutor {
 
 // MARK: Intersect and Union
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Calculates the union of two or more sorted sets and stores the result.
     /// - Note: This operation overwrites any value stored at the destination key.
     ///
@@ -377,7 +377,7 @@ extension RedisCommandExecutor {
 
 // MARK: Range
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Gets the specified range of elements in a sorted set.
     /// - Note: This treats the ordered set as ordered from low to high.
     ///
@@ -437,7 +437,7 @@ extension RedisCommandExecutor {
 
 // MARK: Range by Score
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Gets elements from a sorted set whose score fits within the range specified.
     /// - Note: This treats the ordered set as ordered from low to high.
     ///
@@ -506,7 +506,7 @@ extension RedisCommandExecutor {
 
 // MARK: Range by Lexiographical
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Gets elements from a sorted set whose lexiographical values are between the range specified.
     /// - Important: This assumes all elements in the sorted set have the same score. If not, the returned elements are unspecified.
     /// - Note: This treats the ordered set as ordered from low to high.
@@ -570,7 +570,7 @@ extension RedisCommandExecutor {
 
 // MARK: Remove
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Removes the specified elements from a sorted set.
     ///
     /// See [https://redis.io/commands/zrem](https://redis.io/commands/zrem)

Sources/NIORedis/Commands/StringCommands.swift

@@ -2,7 +2,7 @@ import NIO
 
 // MARK: Get
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Get the value of a key.
     /// - Note: This operation only works with string values.
     ///     The `EventLoopFuture` will fail with a `RedisError` if the value is not a string, such as a Set.
@@ -32,7 +32,7 @@ extension RedisCommandExecutor {
 
 // MARK: Set
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Sets the value stored in the key provided, overwriting the previous value.
     ///
     /// Any previous expiration set on the key is discarded if the SET operation was successful.
@@ -93,7 +93,7 @@ extension RedisCommandExecutor {
 
 // MARK: Increment
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Increments the stored value by 1.
     ///
     /// See [https://redis.io/commands/incr](https://redis.io/commands/incr)
@@ -136,7 +136,7 @@ extension RedisCommandExecutor {
 
 // MARK: Decrement
 
-extension RedisCommandExecutor {
+extension RedisClient {
     /// Decrements the stored value by 1.
     ///
     /// See [https://redis.io/commands/decr](https://redis.io/commands/decr)