code review

Author: hamzahrmalik

Sources/AsyncHTTPClient/HTTPClientConfiguration+SwiftConfiguration.swift

@@ -7,18 +7,14 @@ extension HTTPClient.Configuration {
     ///
     /// ## Configuration keys:
     /// - `dnsOverrides` (string array, optional): Colon-separated host:IP pairs for DNS overrides (e.g., "localhost:127.0.0.1").
-    /// - `redirect.mode` (string, optional, default: "follow"): Redirect handling mode ("follow" or "disallow").
-    /// - `redirect.maxRedirects` (int, optional, default: 5): Maximum allowed redirects (used when mode is "follow").
-    /// - `redirect.allowCycles` (bool, optional, default: false): Allow cyclic redirects (used when mode is "follow").
-    /// - `timeout.connectionMs` (int, optional): Connection timeout in milliseconds.
-    /// - `timeout.readMs` (int, optional): Read timeout in milliseconds.
-    /// - `timeout.writeMs` (int, optional): Write timeout in milliseconds.
-    /// - `connectionPool.idleTimeoutMs` (int, optional, default: 60000): Connection idle timeout in milliseconds.
-    /// - `connectionPool.concurrentHTTP1ConnectionsPerHostSoftLimit` (int, optional, default: 8): Soft limit for concurrent HTTP/1.1 connections per host.
-    /// - `connectionPool.retryConnectionEstablishment` (bool, optional, default: true): Retry failed connection establishment.
-    /// - `connectionPool.preWarmedHTTP1ConnectionCount` (int, optional, default: 0): Number of pre-warmed HTTP/1.1 connections per host.
-    /// - `httpVersion` (string, optional): HTTP version to use ( "automatic" or  "http1Only").
-    /// - `maximumUsesPerConnection` (int, optional): Maximum uses per connection.
+    /// - `redirect` (scoped): Redirect handling configuration read by ``RedirectConfiguration/init(configReader:)``.
+    /// - `timeout` (scoped): Timeout configuration read by ``Timeout/init(configReader:)``.
+    /// - `connectionPool` (scoped): Connection pool configuration read by ``ConnectionPool/init(configReader:)``.
+    /// - `httpVersion` (string, optional, default: automatic): HTTP version to use ( "automatic" or  "http1Only").
+    /// - `maximumUsesPerConnection` (int, optional, default: nil, no limit): Maximum uses per connection.
+    ///
+    /// - Throws: `HTTPClientError.invalidRedirectConfiguration` if redirect mode is invalid.
+    /// - Throws: `HTTPClientError.invalidHTTPVersionConfiguration` if httpVersion is specified but invalid.
     public init(configReader: ConfigReader) throws {
         self.init()
 
@@ -46,7 +42,15 @@ extension HTTPClient.Configuration {
 
 @available(macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0, *)
 extension HTTPClient.Configuration.RedirectConfiguration {
-    fileprivate init(configReader: ConfigReader) throws {
+    /// Initializes redirect configuration from a ConfigReader.
+    ///
+    /// ## Configuration keys:
+    /// - `mode` (string, optional, default: "follow"): Redirect handling mode ("follow" or "disallow").
+    /// - `maxRedirects` (int, optional, default: 5): Maximum allowed redirects when mode is "follow".
+    /// - `allowCycles` (bool, optional, default: false): Allow cyclic redirects when mode is "follow".
+    ///
+    /// - Throws: `HTTPClientError.invalidRedirectConfiguration` if mode is specified but invalid.
+    public init(configReader: ConfigReader) throws {
         guard let mode = configReader.string(forKey: "mode") else {
             // default
             self = .follow(max: 5, allowCycles: false)
@@ -66,7 +70,13 @@ extension HTTPClient.Configuration.RedirectConfiguration {
 
 @available(macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0, *)
 extension HTTPClient.Configuration.Timeout {
-    fileprivate init(configReader: ConfigReader) {
+    /// Initializes timeout configuration from a ConfigReader.
+    ///
+    /// ## Configuration keys:
+    /// - `connectionMs` (int, optional, default: 10,000): Connection timeout in milliseconds.
+    /// - `readMs` (int, optional): Read timeout in milliseconds.
+    /// - `writeMs` (int, optional): Write timeout in milliseconds.
+    public init(configReader: ConfigReader) {
         self.init()
         self.connect = configReader.int(forKey: "connectionMs").map { TimeAmount.milliseconds(Int64($0)) }
         self.read = configReader.int(forKey: "readMs").map { TimeAmount.milliseconds(Int64($0)) }
@@ -76,7 +86,14 @@ extension HTTPClient.Configuration.Timeout {
 
 @available(macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0, *)
 extension HTTPClient.Configuration.ConnectionPool {
-    fileprivate init(configReader: ConfigReader) {
+    /// Initializes connection pool configuration from a ConfigReader.
+    ///
+    /// ## Configuration keys:
+    /// - `idleTimeoutMs` (int, optional, default: 60,000): Connection idle timeout in milliseconds.
+    /// - `concurrentHTTP1ConnectionsPerHostSoftLimit` (int, optional, default: 8): Soft limit for concurrent HTTP/1.1 connections per host.
+    /// - `retryConnectionEstablishment` (bool, optional, default: true): Retry failed connection establishment.
+    /// - `preWarmedHTTP1ConnectionCount` (int, optional, default: 0): Number of pre-warmed HTTP/1.1 connections per host.
+    public init(configReader: ConfigReader) {
         self.init()
         self.idleTimeout = TimeAmount.milliseconds(Int64(configReader.int(forKey: "idleTimeoutMs", default: 60000)))
         self.concurrentHTTP1ConnectionsPerHostSoftLimit = configReader.int(