Skip to content

Commit 5565624

Browse files
committed
Address reviewer comments
1 parent a84f1c0 commit 5565624

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Sources/Kafka/KafkaConsumer.swift

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
//
1313
//===----------------------------------------------------------------------===//
1414

15-
import Dispatch
1615
import Logging
1716
import NIOConcurrencyHelpers
1817
import NIOCore
@@ -74,7 +73,7 @@ public struct KafkaConsumerMessages: Sendable, AsyncSequence {
7473
private let stateMachineHolder: MachineHolder
7574
let pollInterval: Duration
7675
#if swift(>=6.0)
77-
let queue: NaiveQueueExecutor
76+
private let queue: DispatchQueueTaskExecutor
7877
#endif
7978

8079
private final class MachineHolder: Sendable { // only for deinit
@@ -93,7 +92,9 @@ public struct KafkaConsumerMessages: Sendable, AsyncSequence {
9392
self.stateMachineHolder = .init(stateMachine: stateMachine)
9493
self.pollInterval = pollInterval
9594
#if swift(>=6.0)
96-
self.queue = NaiveQueueExecutor(DispatchQueue(label: "com.swift-server.swift-kafka.message-consumer"))
95+
self.queue = DispatchQueueTaskExecutor(
96+
DispatchQueue(label: "com.swift-server.swift-kafka.message-consumer")
97+
)
9798
#endif
9899
}
99100

@@ -111,6 +112,7 @@ public struct KafkaConsumerMessages: Sendable, AsyncSequence {
111112

112113
#if swift(>=6.0)
113114
// Wait on a separate thread for the next message.
115+
// The call below will block for `pollInterval`.
114116
return try await withTaskExecutorPreference(queue) {
115117
try client.consumerPoll(for: Int32(self.pollInterval.inMilliseconds))
116118
}

Sources/Kafka/Utilities/NaiveQueueExecutor.swift renamed to Sources/Kafka/Utilities/DispatchQueueTaskExecutor.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#if swift(>=6.0)
1616
import Dispatch
1717

18-
final class NaiveQueueExecutor: TaskExecutor {
18+
final class DispatchQueueTaskExecutor: TaskExecutor {
1919
let queue: DispatchQueue
2020

2121
init(_ queue: DispatchQueue) {

0 commit comments

Comments
 (0)