Skip to content

Commit 83b5a78

Browse files
KafkaAcknowledgedMessage: fix bug with error msg (#47)
Motivation: * only consumers receive the error message of an acknowledgement through the payload * our implementation only handles acknowledgements for producers, though still uses the message payload for the error message (which only applies to consumers) Modifications: * stop reading acknowledgement error message from message payload for producers * only read underlying rd_kafka_resp_err_t to retrieve error message Result: The error message of a producer acknowledgement should now be determined by the underlying rd_kafka_resp_err_t
1 parent cd0dc2e commit 83b5a78

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

Sources/SwiftKafka/KafkaAcknowledgedMessage.swift

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,7 @@ public struct KafkaAcknowledgedMessage: Hashable {
4343
self.value = ByteBuffer(bytes: valueBufferPointer)
4444

4545
guard rdKafkaMessage.err == RD_KAFKA_RESP_ERR_NO_ERROR else {
46-
var errorStringBuffer = self.value
47-
let errorString = errorStringBuffer.readString(length: errorStringBuffer.readableBytes)
48-
49-
if let errorString {
50-
throw KafkaAcknowledgedMessageError.fromMessage(messageID: self.id, message: errorString)
51-
} else {
52-
throw KafkaAcknowledgedMessageError.fromRDKafkaError(messageID: self.id, error: rdKafkaMessage.err)
53-
}
46+
throw KafkaAcknowledgedMessageError.fromRDKafkaError(messageID: self.id, error: rdKafkaMessage.err)
5447
}
5548

5649
guard let topic = String(validatingUTF8: rd_kafka_topic_name(rdKafkaMessage.rkt)) else {

0 commit comments

Comments
 (0)