Skip to content

Commit a46f57b

Browse files
Remove @unchecked Sendable (#83)
Motivation: apple/swift-nio#2459 has been merged. Modifications: * `Package.swift`: upgrade `swift-nio` to `2.55.0` * make `KafkaAcknowledgedMessage` `Sendable` * make `KafkaProducerMessageID` `Sendable` * remove `@unchecked Sendable` in `KafkaProducer.StateMachine.State` * remove `@unchecked Sendable` in `KafkaConsumer.StateMachine.State`
1 parent aab823f commit a46f57b

File tree

5 files changed

+16
-4
lines changed

5 files changed

+16
-4
lines changed

Package.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ let package = Package(
4141
),
4242
],
4343
dependencies: [
44-
.package(url: "https://github.com/apple/swift-nio.git", from: "2.43.1"),
44+
.package(url: "https://github.com/apple/swift-nio.git", from: "2.55.0"),
4545
.package(url: "https://github.com/swift-server/swift-service-lifecycle.git", from: "2.0.0-alpha.1"),
4646
.package(url: "https://github.com/apple/swift-log.git", from: "1.0.0"),
4747
// The zstd Swift package produces warnings that we cannot resolve:

Sources/SwiftKafka/KafkaAcknowledgedMessage.swift

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import Crdkafka
1616
import NIOCore
1717

1818
/// A message produced by the client and acknowledged by the Kafka cluster.
19-
public struct KafkaAcknowledgedMessage: Hashable {
19+
public struct KafkaAcknowledgedMessage {
2020
/// The unique identifier assigned by the ``KafkaProducer`` when the message was send to Kafka.
2121
/// The same identifier is returned by ``KafkaProducer/send(_:)`` and can be used to correlate
2222
/// a sent message and an acknowledged message.
@@ -66,3 +66,11 @@ public struct KafkaAcknowledgedMessage: Hashable {
6666
self.offset = Int(rdKafkaMessage.offset)
6767
}
6868
}
69+
70+
// MARK: KafkaAcknowledgedMessage + Hashable
71+
72+
extension KafkaAcknowledgedMessage: Hashable {}
73+
74+
// MARK: KafkaAcknowledgedMessage + Sendable
75+
76+
extension KafkaAcknowledgedMessage: Sendable {}

Sources/SwiftKafka/KafkaConsumer.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ extension KafkaConsumer {
247247
let logger: Logger
248248

249249
/// The state of the ``StateMachine``.
250-
enum State: @unchecked Sendable { // TODO: remove @unchecked when https://github.com/apple/swift-nio/pull/2459 is available
250+
enum State: Sendable {
251251
/// The state machine has been initialized with init() but is not yet Initialized
252252
/// using `func initialize()` (required).
253253
case uninitialized

Sources/SwiftKafka/KafkaProducer.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ extension KafkaProducer {
245245
let logger: Logger
246246

247247
/// The state of the ``StateMachine``.
248-
enum State: @unchecked Sendable { // TODO: remove @unchecked when https://github.com/apple/swift-nio/pull/2459 is available
248+
enum State: Sendable {
249249
/// The state machine has been initialized with init() but is not yet Initialized
250250
/// using `func initialize()` (required).
251251
case uninitialized

Sources/SwiftKafka/KafkaProducerMessageID.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,7 @@ extension KafkaProducerMessageID: Comparable {
4242
lhs.rawValue < rhs.rawValue
4343
}
4444
}
45+
46+
// MARK: - KafkaProducerMessageID + Sendable
47+
48+
extension KafkaProducerMessageID: Sendable {}

0 commit comments

Comments
 (0)