Skip to content

Commit ecbd5d9

Browse files
Removed parameter label for KafkaProducer.sendAsync (#38)
Motivation: Parameter label not necessary for single argument function whose parameter type is well known. Modifications: KafkaProducer.sendAsync(message:) -> KafkaProducer.sendAsync(_:)
1 parent ae5982c commit ecbd5d9

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

Sources/SwiftKafka/KafkaProducer.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,16 +172,16 @@ public actor KafkaProducer {
172172
/// - Parameter message: The ``KafkaProducerMessage`` that is sent to the KafkaCluster.
173173
/// - Returns: Unique message identifier matching the `id` property of the corresponding ``KafkaAcknowledgedMessage``
174174
@discardableResult
175-
public func sendAsync(message: KafkaProducerMessage) throws -> UInt {
175+
public func sendAsync(_ message: KafkaProducerMessage) throws -> UInt {
176176
switch self.state {
177177
case .started:
178-
return try self._sendAsync(message: message)
178+
return try self._sendAsync(message)
179179
case .shuttingDown, .shutDown:
180180
throw KafkaError(description: "Trying to invoke method on producer that has been shut down.")
181181
}
182182
}
183183

184-
private func _sendAsync(message: KafkaProducerMessage) throws -> UInt {
184+
private func _sendAsync(_ message: KafkaProducerMessage) throws -> UInt {
185185
let topicHandle = self.createTopicHandleIfNeeded(topic: message.topic)
186186

187187
let keyBytes: [UInt8]?

Tests/IntegrationTests/SwiftKafkaTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ final class SwiftKafkaTests: XCTestCase {
201201
var messageIDs = Set<UInt>()
202202

203203
for message in messages {
204-
messageIDs.insert(try await producer.sendAsync(message: message))
204+
messageIDs.insert(try await producer.sendAsync(message))
205205
}
206206

207207
var acknowledgedMessages = Set<KafkaAcknowledgedMessage>()

Tests/SwiftKafkaTests/KafkaProducerTests.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ final class KafkaProducerTests: XCTestCase {
6060
value: "Hello, World!"
6161
)
6262

63-
let messageID = try await producer.sendAsync(message: message)
63+
let messageID = try await producer.sendAsync(message)
6464

6565
for await messageResult in producer.acknowledgements {
6666
guard case .success(let acknowledgedMessage) = messageResult else {
@@ -87,7 +87,7 @@ final class KafkaProducerTests: XCTestCase {
8787
value: ByteBuffer()
8888
)
8989

90-
let messageID = try await producer.sendAsync(message: message)
90+
let messageID = try await producer.sendAsync(message)
9191

9292
for await messageResult in producer.acknowledgements {
9393
guard case .success(let acknowledgedMessage) = messageResult else {
@@ -121,8 +121,8 @@ final class KafkaProducerTests: XCTestCase {
121121

122122
var messageIDs = Set<UInt>()
123123

124-
messageIDs.insert(try await producer.sendAsync(message: message1))
125-
messageIDs.insert(try await producer.sendAsync(message: message2))
124+
messageIDs.insert(try await producer.sendAsync(message1))
125+
messageIDs.insert(try await producer.sendAsync(message2))
126126

127127
var acknowledgedMessages = Set<KafkaAcknowledgedMessage>()
128128

@@ -161,7 +161,7 @@ final class KafkaProducerTests: XCTestCase {
161161
)
162162

163163
do {
164-
try await producer.sendAsync(message: message)
164+
try await producer.sendAsync(message)
165165
XCTFail("Method should have thrown error")
166166
} catch {}
167167
}

0 commit comments

Comments
 (0)