Skip to content

Commit 20e7fc7

Browse files
committed
Review fixups
1 parent b6fd495 commit 20e7fc7

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

Sources/Prometheus/MetricTypes/Counter.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,11 @@ public class Counter<NumType: Numeric, Labels: MetricLabels>: Metric, Prometheus
7373
var val = self.metrics[labels] ?? self.initialValue
7474
val += amount
7575
self.metrics[labels] = val
76+
done(val)
7677
} else {
7778
self.value += amount
79+
done(self.value)
7880
}
79-
done(self.value)
8081
}
8182
}
8283

Sources/Prometheus/MetricTypes/Gauge.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,7 @@ public class Gauge<NumType: Numeric, Labels: MetricLabels>: Metric, PrometheusHa
109109
/// - done: Completion handler
110110
///
111111
public func inc(_ labels: Labels? = nil, _ done: @escaping (NumType) -> Void = { _ in }) {
112-
self.inc(1, labels) { value in
113-
done(value)
114-
}
112+
self.inc(1, labels, done)
115113
}
116114

117115
/// Decrements the Gauge
@@ -141,9 +139,7 @@ public class Gauge<NumType: Numeric, Labels: MetricLabels>: Metric, PrometheusHa
141139
/// - labels: Labels to attach to the value
142140
///
143141
public func dec(_ labels: Labels? = nil, _ done: @escaping (NumType) -> Void = { _ in }) {
144-
self.dec(1, labels) { value in
145-
done(value)
146-
}
142+
self.dec(1, labels, done)
147143
}
148144

149145
/// Gets the value of the Gauge

Sources/Prometheus/MetricTypes/Summary.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import Dispatch
2-
31
/// Default quantiles used by Summaries
42
public var defaultQuantiles = [0.01, 0.05, 0.5, 0.9, 0.95, 0.99, 0.999]
53

0 commit comments

Comments
 (0)