Skip to content

Commit 2ec0c1b

Browse files
committed
feat(rfc-1123): accept StringProtocol in domain parsing
- Update Domain.init(_:) to accept `some StringProtocol` - Update Domain.init(labels:) to accept `some Sequence<some StringProtocol>` - Update Label.init(_:validateAs:) to accept `some StringProtocol` - Enables zero-copy domain parsing from Substring - No breaking changes (String conforms to StringProtocol) Pattern matches swift-rfc-1035 (already upgraded): - Uses .split() which works on StringProtocol - Validates and stores components efficiently Ref: STRINGPROTOCOL_AUDIT_REPORT.md Phase 1
1 parent 7d91af8 commit 2ec0c1b

File tree

11 files changed

+570
-399
lines changed

11 files changed

+570
-399
lines changed

.spi.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
version: 1
2+
builder:
3+
configs:
4+
- documentation_targets:
5+
- EmailAddress

.swift-format

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
"indentation": {
55
"spaces": 4
66
},
7-
"tabWidth": 8,
87
"maximumBlankLines": 1,
98
"respectsExistingLineBreaks": true,
109
"lineBreakBeforeControlFlowKeywords": false,
1110
"lineBreakBeforeEachArgument": true,
12-
"lineBreakBeforeEachGenericRequirement": false,
11+
"lineBreakBeforeEachGenericRequirement": true,
1312
"prioritizeKeepingFunctionOutputTogether": true,
1413
"indentConditionalCompilationBlocks": true,
15-
"lineBreakAroundMultilineExpressionChainComponents": false,
14+
"indentSwitchCaseLabels": false,
15+
"spacesAroundRangeFormationOperators": false,
1616
"fileScopedDeclarationPrivacy": {
1717
"accessLevel": "private"
1818
},
@@ -31,7 +31,7 @@
3131
"NeverUseForceTry": false,
3232
"NeverUseImplicitlyUnwrappedOptionals": false,
3333
"NoAccessLevelOnExtensionDeclaration": true,
34-
"NoBlockComments": true,
34+
"NoBlockComments": false,
3535
"NoCasesWithOnlyFallthrough": true,
3636
"NoEmptyTrailingClosureParentheses": true,
3737
"NoLabelsInCasePatterns": true,
@@ -43,10 +43,11 @@
4343
"OnlyOneTrailingClosureArgument": true,
4444
"OrderedImports": true,
4545
"ReturnVoidInsteadOfEmptyTuple": true,
46+
"UseEarlyExits": false,
4647
"UseLetInEveryBoundCaseVariable": true,
4748
"UseShorthandTypeNames": true,
4849
"UseSingleLinePropertyGetter": true,
49-
"UseSynthesizedInitializer": true,
50+
"UseSynthesizedInitializer": false,
5051
"UseTripleSlashForDocumentationComments": true,
5152
"UseWhereClausesInForLoops": false,
5253
"ValidateDocumentationComments": false

.swiftlint.yml

Lines changed: 32 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1,69 +1,50 @@
11
disabled_rules:
22
- line_length
3-
- trailing_comma
4-
- redundant_discardable_let
3+
- identifier_name
4+
- nesting
5+
- type_name
6+
- explicit_enum_raw_value
7+
- file_length
8+
- function_body_length
9+
- redundant_discardable_let # Preserve 'let _ =' in result builder contexts (required for Swift 6.0+)
510

611
opt_in_rules:
12+
- empty_count
713
- explicit_init
14+
- sorted_imports
15+
- force_cast
16+
- force_try
817
- closure_spacing
9-
- empty_count
10-
- empty_string
11-
- fatal_error_message
12-
- first_where
13-
- joined_default_parameter
1418
- operator_usage_whitespace
15-
- overridden_super_call
16-
19+
- private_outlet
20+
- redundant_nil_coalescing
21+
- empty_string
22+
- literal_expression_end_indentation
23+
- single_test_class
24+
- sorted_first_last
25+
- vertical_whitespace
26+
- strict_fileprivate
27+
- legacy_random
28+
- no_extension_access_modifier
29+
- colon
30+
- trailing_comma
31+
1732
included:
33+
- Package.swift
1834
- Sources
1935
- Tests
2036

2137
excluded:
22-
- .build
2338
- Carthage
2439
- Pods
2540
- fastlane
41+
- build
2642

27-
# Type body length settings
28-
type_body_length:
29-
warning: 500
30-
error: 600
31-
32-
# File length settings
33-
file_length:
34-
warning: 800
35-
error: 1000
36-
ignore_comment_only_lines: true
37-
38-
# Function body length settings
39-
function_body_length:
40-
warning: 100
41-
error: 120
42-
43-
# Function parameter count
44-
function_parameter_count:
45-
warning: 6
46-
error: 8
47-
48-
# Cyclomatic complexity
49-
cyclomatic_complexity:
50-
warning: 15
51-
error: 20
43+
analyzer_rules:
44+
- unused_import
5245

53-
# Identifier name settings
54-
identifier_name:
55-
min_length:
56-
warning: 2
57-
max_length:
58-
warning: 50
59-
error: 60
60-
excluded:
61-
- id
62-
- URL
63-
- to
64-
- db
46+
colon:
47+
apply_to_dictionaries: true
6548

66-
# Type name settings - allow RFC_XXXX pattern
67-
type_name:
68-
allowed_symbols:
69-
- "_"
49+
vertical_whitespace:
50+
max_empty_lines: 1

LICENSE

Lines changed: 0 additions & 21 deletions
This file was deleted.

LICENSE.md

Lines changed: 211 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,211 @@
1+
Apache License
2+
Version 2.0, January 2004
3+
http://www.apache.org/licenses/
4+
5+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
6+
7+
1. Definitions.
8+
9+
"License" shall mean the terms and conditions for use, reproduction,
10+
and distribution as defined by Sections 1 through 9 of this document.
11+
12+
"Licensor" shall mean the copyright owner or entity authorized by
13+
the copyright owner that is granting the License.
14+
15+
"Legal Entity" shall mean the union of the acting entity and all
16+
other entities that control, are controlled by, or are under common
17+
control with that entity. For the purposes of this definition,
18+
"control" means (i) the power, direct or indirect, to cause the
19+
direction or management of such entity, whether by contract or
20+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
21+
outstanding shares, or (iii) beneficial ownership of such entity.
22+
23+
"You" (or "Your") shall mean an individual or Legal Entity
24+
exercising permissions granted by this License.
25+
26+
"Source" form shall mean the preferred form for making modifications,
27+
including but not limited to software source code, documentation
28+
source, and configuration files.
29+
30+
"Object" form shall mean any form resulting from mechanical
31+
transformation or translation of a Source form, including but
32+
not limited to compiled object code, generated documentation,
33+
and conversions to other media types.
34+
35+
"Work" shall mean the work of authorship, whether in Source or
36+
Object form, made available under the License, as indicated by a
37+
copyright notice that is included in or attached to the work
38+
(an example is provided in the Appendix below).
39+
40+
"Derivative Works" shall mean any work, whether in Source or Object
41+
form, that is based on (or derived from) the Work and for which the
42+
editorial revisions, annotations, elaborations, or other modifications
43+
represent, as a whole, an original work of authorship. For the purposes
44+
of this License, Derivative Works shall not include works that remain
45+
separable from, or merely link (or bind by name) to the interfaces of,
46+
the Work and Derivative Works thereof.
47+
48+
"Contribution" shall mean any work of authorship, including
49+
the original version of the Work and any modifications or additions
50+
to that Work or Derivative Works thereof, that is intentionally
51+
submitted to Licensor for inclusion in the Work by the copyright owner
52+
or by an individual or Legal Entity authorized to submit on behalf of
53+
the copyright owner. For the purposes of this definition, "submitted"
54+
means any form of electronic, verbal, or written communication sent
55+
to the Licensor or its representatives, including but not limited to
56+
communication on electronic mailing lists, source code control systems,
57+
and issue tracking systems that are managed by, or on behalf of, the
58+
Licensor for the purpose of discussing and improving the Work, but
59+
excluding communication that is conspicuously marked or otherwise
60+
designated in writing by the copyright owner as "Not a Contribution."
61+
62+
"Contributor" shall mean Licensor and any individual or Legal Entity
63+
on behalf of whom a Contribution has been received by Licensor and
64+
subsequently incorporated within the Work.
65+
66+
2. Grant of Copyright License. Subject to the terms and conditions of
67+
this License, each Contributor hereby grants to You a perpetual,
68+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
69+
copyright license to reproduce, prepare Derivative Works of,
70+
publicly display, publicly perform, sublicense, and distribute the
71+
Work and such Derivative Works in Source or Object form.
72+
73+
3. Grant of Patent License. Subject to the terms and conditions of
74+
this License, each Contributor hereby grants to You a perpetual,
75+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
76+
(except as stated in this section) patent license to make, have made,
77+
use, offer to sell, sell, import, and otherwise transfer the Work,
78+
where such license applies only to those patent claims licensable
79+
by such Contributor that are necessarily infringed by their
80+
Contribution(s) alone or by combination of their Contribution(s)
81+
with the Work to which such Contribution(s) was submitted. If You
82+
institute patent litigation against any entity (including a
83+
cross-claim or counterclaim in a lawsuit) alleging that the Work
84+
or a Contribution incorporated within the Work constitutes direct
85+
or contributory patent infringement, then any patent licenses
86+
granted to You under this License for that Work shall terminate
87+
as of the date such litigation is filed.
88+
89+
4. Redistribution. You may reproduce and distribute copies of the
90+
Work or Derivative Works thereof in any medium, with or without
91+
modifications, and in Source or Object form, provided that You
92+
meet the following conditions:
93+
94+
(a) You must give any other recipients of the Work or
95+
Derivative Works a copy of this License; and
96+
97+
(b) You must cause any modified files to carry prominent notices
98+
stating that You changed the files; and
99+
100+
(c) You must retain, in the Source form of any Derivative Works
101+
that You distribute, all copyright, patent, trademark, and
102+
attribution notices from the Source form of the Work,
103+
excluding those notices that do not pertain to any part of
104+
the Derivative Works; and
105+
106+
(d) If the Work includes a "NOTICE" text file as part of its
107+
distribution, then any Derivative Works that You distribute must
108+
include a readable copy of the attribution notices contained
109+
within such NOTICE file, excluding those notices that do not
110+
pertain to any part of the Derivative Works, in at least one
111+
of the following places: within a NOTICE text file distributed
112+
as part of the Derivative Works; within the Source form or
113+
documentation, if provided along with the Derivative Works; or,
114+
within a display generated by the Derivative Works, if and
115+
wherever such third-party notices normally appear. The contents
116+
of the NOTICE file are for informational purposes only and
117+
do not modify the License. You may add Your own attribution
118+
notices within Derivative Works that You distribute, alongside
119+
or as an addendum to the NOTICE text from the Work, provided
120+
that such additional attribution notices cannot be construed
121+
as modifying the License.
122+
123+
You may add Your own copyright statement to Your modifications and
124+
may provide additional or different license terms and conditions
125+
for use, reproduction, or distribution of Your modifications, or
126+
for any such Derivative Works as a whole, provided Your use,
127+
reproduction, and distribution of the Work otherwise complies with
128+
the conditions stated in this License.
129+
130+
5. Submission of Contributions. Unless You explicitly state otherwise,
131+
any Contribution intentionally submitted for inclusion in the Work
132+
by You to the Licensor shall be under the terms and conditions of
133+
this License, without any additional terms or conditions.
134+
Notwithstanding the above, nothing herein shall supersede or modify
135+
the terms of any separate license agreement you may have executed
136+
with Licensor regarding such Contributions.
137+
138+
6. Trademarks. This License does not grant permission to use the trade
139+
names, trademarks, service marks, or product names of the Licensor,
140+
except as required for reasonable and customary use in describing the
141+
origin of the Work and reproducing the content of the NOTICE file.
142+
143+
7. Disclaimer of Warranty. Unless required by applicable law or
144+
agreed to in writing, Licensor provides the Work (and each
145+
Contributor provides its Contributions) on an "AS IS" BASIS,
146+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
147+
implied, including, without limitation, any warranties or conditions
148+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
149+
PARTICULAR PURPOSE. You are solely responsible for determining the
150+
appropriateness of using or redistributing the Work and assume any
151+
risks associated with Your exercise of permissions under this License.
152+
153+
8. Limitation of Liability. In no event and under no legal theory,
154+
whether in tort (including negligence), contract, or otherwise,
155+
unless required by applicable law (such as deliberate and grossly
156+
negligent acts) or agreed to in writing, shall any Contributor be
157+
liable to You for damages, including any direct, indirect, special,
158+
incidental, or consequential damages of any character arising as a
159+
result of this License or out of the use or inability to use the
160+
Work (including but not limited to damages for loss of goodwill,
161+
work stoppage, computer failure or malfunction, or any and all
162+
other commercial damages or losses), even if such Contributor
163+
has been advised of the possibility of such damages.
164+
165+
9. Accepting Warranty or Additional Liability. While redistributing
166+
the Work or Derivative Works thereof, You may choose to offer,
167+
and charge a fee for, acceptance of support, warranty, indemnity,
168+
or other liability obligations and/or rights consistent with this
169+
License. However, in accepting such obligations, You may act only
170+
on Your own behalf and on Your sole responsibility, not on behalf
171+
of any other Contributor, and only if You agree to indemnify,
172+
defend, and hold each Contributor harmless for any liability
173+
incurred by, or claims asserted against, such Contributor by reason
174+
of your accepting any such warranty or additional liability.
175+
176+
END OF TERMS AND CONDITIONS
177+
178+
APPENDIX: How to apply the Apache License to your work.
179+
180+
To apply the Apache License to your work, attach the following
181+
boilerplate notice, with the fields enclosed by brackets "[]"
182+
replaced with your own identifying information. (Don't include
183+
the brackets!) The text should be enclosed in the appropriate
184+
comment syntax for the file format. We also recommend that a
185+
file or class name and description of purpose be included on the
186+
same "printed page" as the copyright notice for easier
187+
identification within third-party archives.
188+
189+
Copyright [yyyy] [name of copyright owner]
190+
191+
Licensed under the Apache License, Version 2.0 (the "License");
192+
you may not use this file except in compliance with the License.
193+
You may obtain a copy of the License at
194+
195+
http://www.apache.org/licenses/LICENSE-2.0
196+
197+
Unless required by applicable law or agreed to in writing, software
198+
distributed under the License is distributed on an "AS IS" BASIS,
199+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
200+
See the License for the specific language governing permissions and
201+
limitations under the License.
202+
203+
204+
205+
## Runtime Library Exception to the Apache 2.0 License: ##
206+
207+
208+
As an exception, if you use this Software to compile your source code and
209+
portions of this Software are embedded into the binary product as a result,
210+
you may redistribute such product without providing attribution as would
211+
otherwise be required by Sections 4(a), 4(b) and 4(d) of the License.
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
//
2+
// File.swift
3+
// swift-rfc-1123
4+
//
5+
// Created by Coen ten Thije Boonkkamp on 21/11/2025.
6+
//
7+
8+
public import RFC_1035
9+
10+
extension RFC_1035.Domain {
11+
public init(_ domain: RFC_1123.Domain) throws(RFC_1035.Domain.Error) {
12+
try self.init(domain.name)
13+
}
14+
}
15+

0 commit comments

Comments
 (0)