Skip to content

Commit 1b585ed

Browse files
committed
Remove early exit in licensecheck
# Motivation When onboarding a new repo it is often the case that new file extensions need to be added to this repo. Currently, we fail early when we encounter an unknown extension. # Modification This PR changes to produce an error when we encounter an unknown extension but continue. # Result Makes it easier to onboard new repos.
1 parent 8d16220 commit 1b585ed

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.github/workflows/scripts/check-license-header.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@ while IFS= read -r file_path; do
5555
rb) expected_file_header=$(cat <(echo '#!/usr/bin/env ruby') <(sed -e 's|@@|##|g' <<<"${expected_file_header_template}")) ;;
5656
in) expected_file_header=$(sed -e 's|@@|##|g' <<<"${expected_file_header_template}") ;;
5757
cmake) expected_file_header=$(sed -e 's|@@|##|g' <<<"${expected_file_header_template}") ;;
58-
*) fatal "Unsupported file extension for file (exclude or update this script): ${file_path}" ;;
58+
*)
59+
error "Unsupported file extension ${file_extension} for file (exclude or update this script): ${file_path}"
60+
paths_with_missing_license+=("${file_path} ")
61+
;;
5962
esac
6063
expected_file_header_linecount=$(wc -l <<<"${expected_file_header}")
6164

0 commit comments

Comments
 (0)