Skip to content

Add a soundness check to lint Python files #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add a soundness check to lint Python files #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/soundness.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ on:
type: boolean
description: "Boolean to enable the YAML lint job. Defaults to true."
default: true
python_lint_check_enabled:
type: boolean
description: "Boolean to enable the Python lint check job. Defaults to true."
default: true

## We are cancelling previously triggered workflow runs
concurrency:
Expand Down Expand Up @@ -200,3 +204,18 @@ jobs:
run: |
curl -s https://raw.githubusercontent.com/swiftlang/github-workflows/refs/heads/main/.github/workflows/configs/yamllint.yml > /tmp/yamllint.yml
yamllint --strict --config-file /tmp/yamllint.yml ${GITHUB_WORKSPACE}
python-lint-check:
name: Python lint check
if: ${{ inputs.python_lint_check_enabled }}
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
persist-credentials: false
- name: Run flake8
run: |
pip3 install flake8 flake8-import-order --break-system-packages
Copy link

@kkebo kkebo Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you may know, it seems that ubuntu-latest on GitHub-hosted runners is currently in the process of migrating to Ubuntu 24.04. Until it's completed, Ubuntu 22.04 may be used, and on Ubuntu 22.04, this command will fail because its pip3 is old and does not have --break-system-packages.

Announcement: actions/runner-images#10636

Failure case: https://github.com/kkebo/swift-format/actions/runs/11299915833/job/31431847497

Since the migration will be completed soon, I think we can ignore it.

Copy link
Member Author

@ahoppen ahoppen Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed it: #28

Copy link

@kkebo kkebo Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

cd ${GITHUB_WORKSPACE}
flake8