Skip to content

Conversation

@jrflat
Copy link
Contributor

@jrflat jrflat commented Aug 5, 2025

Enable alias expansion and run alias swift="$SWIFT_EXECUTABLE_FOR_(NAME)_SDK" before performing the build so that we can support custom swift build commands while still using the correct executable.

I'll add a commit that points to the script URL on my branch for testing this PR, then remove it before merging.

Resolves #147

@jrflat jrflat requested a review from a team as a code owner August 5, 2025 01:22
Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, make sure to review the forked repo path once test is completed.

  • Revert the script back to swiftlang/github-workflows url

@jrflat
Copy link
Contributor Author

jrflat commented Aug 5, 2025

Reverted the script URL back to swiftlang:main. Previous successful run for reference: https://github.com/swiftlang/github-workflows/actions/runs/16738403255

@jrflat
Copy link
Contributor Author

jrflat commented Aug 5, 2025

This is going to conflict with the name/description changes in #150. I'll wait for that to land or remove my changes that'll conflict.

Update: Removed the description changes that would conflict from this PR.

@jrflat
Copy link
Contributor Author

jrflat commented Aug 6, 2025

I'm going to squash commits and re-test to make the PR branch testing dance clearer

@jrflat jrflat force-pushed the custom-command-for-sdk-builds branch from 2cca7da to f956c65 Compare August 6, 2025 17:42
@jrflat
Copy link
Contributor Author

jrflat commented Aug 6, 2025

Previous commit using this branch for the script URL is green. I've now reverted the script URL back to swiftlang:main. This PR also no longer conflicts with Max's PR.

@shahmishal I think this is ready to merge if it looks good to you, thanks!

@shahmishal shahmishal merged commit b8f8a6c into swiftlang:main Aug 6, 2025
42 of 46 checks passed
@jakepetroules
Copy link
Contributor

Thanks for landing this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux Static SDK and WebAssembly build commands are not overridable

3 participants