Skip to content

Conversation

@jakepetroules
Copy link
Contributor

@jakepetroules jakepetroules commented Nov 19, 2025

This causes failures to be ignored when -o pipefail is not set.
checkout@v1 and checkout@v4 differ in their behavior, try to make v1 clone the workflows repo in the same place as v4.
@jakepetroules jakepetroules marked this pull request as ready for review November 19, 2025 08:33
@jakepetroules jakepetroules requested a review from a team as a code owner November 19, 2025 08:33
Copy link
Member

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the motivation and/or add a test for it?

@jakepetroules
Copy link
Contributor Author

I updated the description with the commit comments.

This can save tens of seconds on some of the soundness checks.
Copy link

@justice-adams-apple justice-adams-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahmishal shahmishal merged commit 54f71e9 into swiftlang:main Nov 20, 2025
102 of 103 checks passed
@jakepetroules jakepetroules deleted the al2 branch November 20, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants