Skip to content

Commit 1c84c9b

Browse files
[lldb] Don't call FixDataAddress when reading fp in ReadGPRValue (llvm#159606)
Based on testing on processors that use pointer metadata, and with all the work done to delay calls to FixDataAddress, this is no longer necessary. Note that, with debugserver in particular, this is an NFC change: the code path here is for frame zero, and debugserver will strip metadata when reading fp from frame zero anyway. (cherry picked from commit bce48c8)
1 parent 5462859 commit 1c84c9b

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

lldb/source/Target/RegisterContextUnwind.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2182,9 +2182,6 @@ bool RegisterContextUnwind::ReadGPRValue(lldb::RegisterKind register_kind,
21822182
if (generic_regnum == LLDB_REGNUM_GENERIC_PC ||
21832183
generic_regnum == LLDB_REGNUM_GENERIC_RA)
21842184
value = abi_sp->FixCodeAddress(value);
2185-
if (generic_regnum == LLDB_REGNUM_GENERIC_SP ||
2186-
generic_regnum == LLDB_REGNUM_GENERIC_FP)
2187-
value = abi_sp->FixDataAddress(value);
21882185
}
21892186
return true;
21902187
}

0 commit comments

Comments
 (0)