[lldb/API] Hoist some of SBFrame Swift logic to lldb_private::StackFrame (NFC)

This patch moves the logic for IsSwiftThunk and GetLanguageSpecificData
from SBFrame to the lldb_private::StackFrame class so it can be re-used
elsewhere.

Signed-off-by: Med Ismail Bennani <[email protected]>

Author: medismailben

lldb/include/lldb/Target/StackFrame.h

@@ -412,6 +412,16 @@ class StackFrame : public ExecutionContextScope,
   /// system implementation details this way.
   bool IsHidden();
 
+  /// Query whether this frame is a Swift Thunk.
+  bool IsSwiftThunk();
+
+  /// Get this frame language specific data.
+  ///
+  /// \return
+  ///   The StructuredDataImpl object containing the language specific data. Can
+  ///   be null.
+  StructuredDataImpl *GetLanguageSpecificData();
+
   /// Get the frame's demangled name.
   ///
   ///  /// \return

lldb/source/API/SBFrame.cpp

@@ -56,13 +56,6 @@
 
 #include "llvm/Support/PrettyStackTrace.h"
 
-// BEGIN SWIFT
-#include "lldb/Target/LanguageRuntime.h"
-#ifdef LLDB_ENABLE_SWIFT
-#include "Plugins/LanguageRuntime/Swift/SwiftLanguageRuntime.h"
-#endif
-// END SWIFT
-
 using namespace lldb;
 using namespace lldb_private;
 
@@ -1249,13 +1242,10 @@ lldb::LanguageType SBFrame::GuessLanguage() const {
 lldb::SBStructuredData SBFrame::GetLanguageSpecificData() const {
   std::unique_lock<std::recursive_mutex> lock;
   ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
-  auto *process = exe_ctx.GetProcessPtr();
   auto *frame = exe_ctx.GetFramePtr();
-  if (process && frame)
-    if (auto *runtime = process->GetLanguageRuntime(
-            frame->GuessLanguage().AsLanguageType()))
-      if (auto *data = runtime->GetLanguageSpecificData(*frame))
-        return SBStructuredData(*data);
+  if (frame)
+    if (StructuredDataImpl *data = frame->GetLanguageSpecificData())
+      return SBStructuredData(*data);
 
   return {};
 }
@@ -1276,14 +1266,7 @@ bool SBFrame::IsSwiftThunk() const {
   frame = exe_ctx.GetFramePtr();
   if (!frame)
     return false;
-  SymbolContext sc;
-  sc = frame->GetSymbolContext(eSymbolContextSymbol);
-  if (!sc.symbol)
-    return false;
-  auto *runtime = process->GetLanguageRuntime(eLanguageTypeSwift);
-  if (!runtime)
-    return false;
-  return runtime->IsSymbolARuntimeThunk(*sc.symbol);
+  return frame->IsSwiftThunk();
 }
 // END SWIFT
 

lldb/source/Target/StackFrame.cpp

@@ -34,6 +34,11 @@
 #include "lldb/ValueObject/ValueObjectMemory.h"
 #include "lldb/ValueObject/ValueObjectVariable.h"
 
+#include "lldb/Target/LanguageRuntime.h"
+#ifdef LLDB_ENABLE_SWIFT
+#include "Plugins/LanguageRuntime/Swift/SwiftLanguageRuntime.h"
+#endif
+
 #include "lldb/lldb-enumerations.h"
 
 #include <memory>
@@ -1215,6 +1220,38 @@ bool StackFrame::IsHidden() {
   return false;
 }
 
+bool StackFrame::IsSwiftThunk() {
+  ThreadSP thread_sp = GetThread();
+  if (!thread_sp)
+    return false;
+  ProcessSP process_sp = thread_sp->GetProcess();
+  if (!process_sp)
+    return false;
+
+  SymbolContext sc = GetSymbolContext(eSymbolContextSymbol);
+  if (!sc.symbol)
+    return false;
+  auto *runtime = process_sp->GetLanguageRuntime(eLanguageTypeSwift);
+  if (!runtime)
+    return false;
+  return runtime->IsSymbolARuntimeThunk(*sc.symbol);
+}
+
+StructuredDataImpl *StackFrame::GetLanguageSpecificData() {
+  ThreadSP thread_sp = GetThread();
+  if (!thread_sp)
+    return {};
+  ProcessSP process_sp = thread_sp->GetProcess();
+  if (!process_sp)
+    return {};
+
+  if (auto *runtime =
+          process_sp->GetLanguageRuntime(GuessLanguage().AsLanguageType()))
+    if (auto *data = runtime->GetLanguageSpecificData(*this))
+      return data;
+  return {};
+}
+
 const char *StackFrame::GetFunctionName() {
   const char *name = nullptr;
   SymbolContext sc = GetSymbolContext(