[lldb][test] Replace use of p with expression (NFC)

In API tests, replace use of the `p` alias with the `expression` command.

To avoid conflating tests of the alias with tests of the expression command,
this patch canonicalizes to the use `expression`.

Differential Revision: https://reviews.llvm.org/D141539

(cherry picked from commit 4076664)
(cherry picked from commit a7bf4d6)

Author: kastiglione

lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py

@@ -19,7 +19,7 @@ def test_with(self):
         self.build()
         lldbutil.run_to_source_breakpoint(self, "// break here", lldb.SBFileSpec("main.cpp"))
 
-        self.expect("print str",
+        self.expect("expression str",
                     substrs=['Hello world'])
 
         # Calling this function now succeeds, but we follow the typedef return type through to
@@ -32,5 +32,5 @@ def test_with(self):
         if triple in ["arm64-apple-ios", "arm64e-apple-ios", "arm64-apple-tvos", "armv7k-apple-watchos", "arm64-apple-bridgeos", "arm64_32-apple-watchos"]:
             do_cstr_test = False
         if do_cstr_test:
-            self.expect("print str.c_str()",
+            self.expect("expression str.c_str()",
                         substrs=['Hello world'])

lldb/test/API/commands/expression/codegen-crash-typedefdecl-not-in_declcontext/main.cpp

@@ -23,7 +23,7 @@ struct E {
   E(B &b) : b_ref(b) {}
   NS::DW f() { return {}; };
   void g() {
-    return; //%self.expect("p b_ref", substrs=['(B) $0 =', '(spd = NS::DW', 'a = 0)'])
+    return; //%self.expect("expression b_ref", substrs=['(B) $0 =', '(spd = NS::DW', 'a = 0)'])
   }
 
   B &b_ref;

lldb/test/API/commands/expression/persist_objc_pointeetype/TestPersistObjCPointeeType.py

@@ -38,11 +38,16 @@ def cleanup():
 
         self.runCmd("run", RUN_SUCCEEDED)
 
-        self.expect("p *self", substrs=['_sc_name = nil',
-                                        '_sc_name2 = nil',
-                                        '_sc_name3 = nil',
-                                        '_sc_name4 = nil',
-                                        '_sc_name5 = nil',
-                                        '_sc_name6 = nil',
-                                        '_sc_name7 = nil',
-                                        '_sc_name8 = nil'])
+        self.expect(
+            "expression *self",
+            substrs=[
+                "_sc_name = nil",
+                "_sc_name2 = nil",
+                "_sc_name3 = nil",
+                "_sc_name4 = nil",
+                "_sc_name5 = nil",
+                "_sc_name6 = nil",
+                "_sc_name7 = nil",
+                "_sc_name8 = nil",
+            ],
+        )

lldb/test/API/commands/expression/rdar44436068/main.c

@@ -2,7 +2,7 @@ int main(void)
 {
     __int128_t n = 1;
     n = n + n;
-    return n; //%self.expect("p n", substrs=['(__int128_t) $0 = 2'])
-              //%self.expect("p n + 6", substrs=['(__int128_t) $1 = 8'])
-              //%self.expect("p n + n", substrs=['(__int128_t) $2 = 4'])
+    return n; //%self.expect("expression n", substrs=['(__int128_t) $0 = 2'])
+              //%self.expect("expression n + 6", substrs=['(__int128_t) $1 = 8'])
+              //%self.expect("expression n + n", substrs=['(__int128_t) $2 = 4'])
 }

lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_static_config/TestSVERegisters.py

@@ -163,7 +163,7 @@ def test_sve_registers_read_write(self):
         self.check_sve_regs_read(z_reg_size)
 
         # Evaluate simple expression and print function expr_eval_func address.
-        self.expect("p expr_eval_func", substrs=["= 0x"])
+        self.expect("expression expr_eval_func", substrs=["= 0x"])
 
         # Evaluate expression call function expr_eval_func.
         self.expect_expr("expr_eval_func()",

lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py

@@ -30,7 +30,7 @@ def test(self):
         self.runCmd(f"settings set symbols.clang-modules-cache-path '{mod_cache}'")
 
         # Cause lldb to generate a Darwin-*.pcm
-        self.runCmd("p @import Darwin")
+        self.runCmd("expression @import Darwin")
 
         # root/<config-hash>/<module-name>-<modulemap-path-hash>.pcm
         pcm_paths = glob.glob(os.path.join(mod_cache, '*', 'Darwin-*.pcm'))

lldb/test/API/functionalities/alias/Makefile

@@ -0,0 +1,4 @@
+C_SOURCES := main.c
+CFLAGS_EXTRAS := -std=c99
+
+include Makefile.rules

lldb/test/API/functionalities/alias/TestPAlias.py

@@ -0,0 +1,11 @@
+import lldb
+from lldbsuite.test.lldbtest import TestBase
+from lldbsuite.test import lldbutil
+
+
+class TestCase(TestBase):
+    def test(self):
+        self.build()
+        lldbutil.run_to_source_breakpoint(self, "return", lldb.SBFileSpec("main.c"))
+        self.expect("p -g", substrs=["$0 = -"])
+        self.expect("p -i0 -g", error=True)

lldb/test/API/functionalities/alias/main.c

@@ -0,0 +1,4 @@
+int main() {
+  int g = 41;
+  return 0;
+}

lldb/test/API/functionalities/backticks/TestBackticksWithoutATarget.py

@@ -15,5 +15,5 @@ class BackticksWithNoTargetTestCase(TestBase):
     @no_debug_info_test
     def test_backticks_no_target(self):
         """A simple test of backticks without a target."""
-        self.expect("print `1+2-3`",
+        self.expect("expression `1+2-3`",
                     substrs=[' = 0'])