Skip to content

Commit 351fddd

Browse files
cmticeJDevlieghere
authored andcommitted
[lldb-dap] Fix typescript issue in updated typescript code. (llvm#156117)
After PR 155021 landed, some typescript 'promises' in async functions were not 'await'ed, which caused us some build failures. This fixes that by adding 'await' in the appropriate places. (cherry picked from commit 6d43551)
1 parent 98db3c1 commit 351fddd

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lldb/tools/lldb-dap/src-ts/ui/symbols-provider.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,18 +61,18 @@ export class SymbolsProvider extends DisposableContext {
6161
return;
6262
}
6363

64-
this.showSymbolsForModule(session, selectedModule.module);
64+
await this.showSymbolsForModule(session, selectedModule.module);
6565
}
6666

6767
private async showSymbolsForModule(session: vscode.DebugSession, module: DebugProtocol.Module) {
6868
try {
6969
const symbols = await this.getSymbolsForModule(session, module.id.toString());
70-
this.showSymbolsInNewTab(module.name.toString(), symbols);
70+
await this.showSymbolsInNewTab(module.name.toString(), symbols);
7171
} catch (error) {
7272
if (error instanceof Error) {
73-
vscode.window.showErrorMessage("Failed to retrieve symbols: " + error.message);
73+
await vscode.window.showErrorMessage("Failed to retrieve symbols: " + error.message);
7474
} else {
75-
vscode.window.showErrorMessage("Failed to retrieve symbols due to an unknown error.");
75+
await vscode.window.showErrorMessage("Failed to retrieve symbols due to an unknown error.");
7676
}
7777

7878
return;
@@ -106,7 +106,7 @@ export class SymbolsProvider extends DisposableContext {
106106
const symbolsTableScriptPath = panel.webview.asWebviewUri(vscode.Uri.joinPath(this.getExtensionResourcePath(), "symbols-table-view.js"));
107107

108108
panel.webview.html = getSymbolsTableHTMLContent(tabulatorJsPath, tabulatorCssPath, symbolsTableScriptPath);
109-
panel.webview.postMessage({ command: "updateSymbols", symbols: symbols });
109+
await panel.webview.postMessage({ command: "updateSymbols", symbols: symbols });
110110
}
111111

112112
private getExtensionResourcePath(): vscode.Uri {

0 commit comments

Comments
 (0)