Skip to content

Commit 3a9a0e8

Browse files
tomershafirtomershafir
committed
[AArch64] Remove wrong processor feature (llvm#151289)
`fmov dX, dY` is not a preferred instruction. Previously introduced by: llvm#144152 (cherry-pick ffddf33)
1 parent ffb598e commit 3a9a0e8

File tree

2 files changed

+0
-44
lines changed

2 files changed

+0
-44
lines changed

‎llvm/lib/Target/AArch64/AArch64Processors.td‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,6 @@ def TuneAppleA7 : SubtargetFeature<"apple-a7", "ARMProcFamily", "AppleA7",
312312
FeatureFuseAES, FeatureFuseCryptoEOR,
313313
FeatureStorePairSuppress,
314314
FeatureZCRegMoveGPR64,
315-
FeatureZCRegMoveFPR64,
316315
FeatureZCZeroing,
317316
FeatureZCZeroingFPWorkaround]>;
318317

@@ -326,7 +325,6 @@ def TuneAppleA10 : SubtargetFeature<"apple-a10", "ARMProcFamily", "AppleA10",
326325
FeatureFuseCryptoEOR,
327326
FeatureStorePairSuppress,
328327
FeatureZCRegMoveGPR64,
329-
FeatureZCRegMoveFPR64,
330328
FeatureZCZeroing]>;
331329

332330
def TuneAppleA11 : SubtargetFeature<"apple-a11", "ARMProcFamily", "AppleA11",
@@ -339,7 +337,6 @@ def TuneAppleA11 : SubtargetFeature<"apple-a11", "ARMProcFamily", "AppleA11",
339337
FeatureFuseCryptoEOR,
340338
FeatureStorePairSuppress,
341339
FeatureZCRegMoveGPR64,
342-
FeatureZCRegMoveFPR64,
343340
FeatureZCZeroing]>;
344341

345342
def TuneAppleA12 : SubtargetFeature<"apple-a12", "ARMProcFamily", "AppleA12",
@@ -352,7 +349,6 @@ def TuneAppleA12 : SubtargetFeature<"apple-a12", "ARMProcFamily", "AppleA12",
352349
FeatureFuseCryptoEOR,
353350
FeatureStorePairSuppress,
354351
FeatureZCRegMoveGPR64,
355-
FeatureZCRegMoveFPR64,
356352
FeatureZCZeroing]>;
357353

358354
def TuneAppleA13 : SubtargetFeature<"apple-a13", "ARMProcFamily", "AppleA13",
@@ -365,7 +361,6 @@ def TuneAppleA13 : SubtargetFeature<"apple-a13", "ARMProcFamily", "AppleA13",
365361
FeatureFuseCryptoEOR,
366362
FeatureStorePairSuppress,
367363
FeatureZCRegMoveGPR64,
368-
FeatureZCRegMoveFPR64,
369364
FeatureZCZeroing]>;
370365

371366
def TuneAppleA14 : SubtargetFeature<"apple-a14", "ARMProcFamily", "AppleA14",
@@ -383,7 +378,6 @@ def TuneAppleA14 : SubtargetFeature<"apple-a14", "ARMProcFamily", "AppleA14",
383378
FeatureFuseLiterals,
384379
FeatureStorePairSuppress,
385380
FeatureZCRegMoveGPR64,
386-
FeatureZCRegMoveFPR64,
387381
FeatureZCZeroing]>;
388382

389383
def TuneAppleA15 : SubtargetFeature<"apple-a15", "ARMProcFamily", "AppleA15",
@@ -401,7 +395,6 @@ def TuneAppleA15 : SubtargetFeature<"apple-a15", "ARMProcFamily", "AppleA15",
401395
FeatureFuseLiterals,
402396
FeatureStorePairSuppress,
403397
FeatureZCRegMoveGPR64,
404-
FeatureZCRegMoveFPR64,
405398
FeatureZCZeroing]>;
406399

407400
def TuneAppleA16 : SubtargetFeature<"apple-a16", "ARMProcFamily", "AppleA16",
@@ -419,7 +412,6 @@ def TuneAppleA16 : SubtargetFeature<"apple-a16", "ARMProcFamily", "AppleA16",
419412
FeatureFuseLiterals,
420413
FeatureStorePairSuppress,
421414
FeatureZCRegMoveGPR64,
422-
FeatureZCRegMoveFPR64,
423415
FeatureZCZeroing]>;
424416

425417
def TuneAppleA17 : SubtargetFeature<"apple-a17", "ARMProcFamily", "AppleA17",
@@ -437,7 +429,6 @@ def TuneAppleA17 : SubtargetFeature<"apple-a17", "ARMProcFamily", "AppleA17",
437429
FeatureFuseLiterals,
438430
FeatureStorePairSuppress,
439431
FeatureZCRegMoveGPR64,
440-
FeatureZCRegMoveFPR64,
441432
FeatureZCZeroing]>;
442433

443434
def TuneAppleM4 : SubtargetFeature<"apple-m4", "ARMProcFamily", "AppleM4",
@@ -454,7 +445,6 @@ def TuneAppleM4 : SubtargetFeature<"apple-m4", "ARMProcFamily", "AppleM4",
454445
FeatureFuseCryptoEOR,
455446
FeatureFuseLiterals,
456447
FeatureZCRegMoveGPR64,
457-
FeatureZCRegMoveFPR64,
458448
FeatureZCZeroing
459449
]>;
460450

‎llvm/test/CodeGen/AArch64/arm64-zero-cycle-regmov-fpr.ll‎

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
; RUN: llc < %s -mtriple=arm64-linux-gnu | FileCheck %s -check-prefixes=NOTCPU-LINUX --match-full-lines
22
; RUN: llc < %s -mtriple=arm64-apple-macosx -mcpu=generic | FileCheck %s -check-prefixes=NOTCPU-APPLE --match-full-lines
3-
; RUN: llc < %s -mtriple=arm64-apple-macosx -mcpu=apple-m1 | FileCheck %s -check-prefixes=CPU --match-full-lines
4-
; RUN: llc < %s -mtriple=arm64-apple-macosx -mcpu=apple-m1 -mattr=-zcm-fpr64 | FileCheck %s -check-prefixes=NOTATTR --match-full-lines
53
; RUN: llc < %s -mtriple=arm64-apple-macosx -mattr=+zcm-fpr64 | FileCheck %s -check-prefixes=ATTR --match-full-lines
64

75
define void @zero_cycle_regmov_FPR32(float %a, float %b, float %c, float %d) {
@@ -23,22 +21,6 @@ entry:
2321
; NOTCPU-APPLE: fmov s0, [[REG1]]
2422
; NOTCPU-APPLE: fmov s1, [[REG2]]
2523

26-
; CPU: fmov [[REG2:d[0-9]+]], d3
27-
; CPU: fmov [[REG1:d[0-9]+]], d2
28-
; CPU: fmov d0, d2
29-
; CPU: fmov d1, d3
30-
; CPU-NEXT: bl {{_?foo_float}}
31-
; CPU: fmov d0, [[REG1]]
32-
; CPU: fmov d1, [[REG2]]
33-
34-
; NOTATTR: fmov [[REG2:s[0-9]+]], s3
35-
; NOTATTR: fmov [[REG1:s[0-9]+]], s2
36-
; NOTATTR: fmov s0, s2
37-
; NOTATTR: fmov s1, s3
38-
; NOTATTR-NEXT: bl {{_?foo_float}}
39-
; NOTATTR: fmov s0, [[REG1]]
40-
; NOTATTR: fmov s1, [[REG2]]
41-
4224
; ATTR: fmov d0, d2
4325
; ATTR: fmov d1, d3
4426
; ATTR: fmov [[REG2:d[0-9]+]], d3
@@ -72,22 +54,6 @@ entry:
7254
; NOTCPU-APPLE: fmov s0, [[REG1]]
7355
; NOTCPU-APPLE: fmov s1, [[REG2]]
7456

75-
; CPU: fmov [[REG2:d[0-9]+]], d3
76-
; CPU: fmov [[REG1:d[0-9]+]], d2
77-
; CPU: fmov d0, d2
78-
; CPU: fmov d1, d3
79-
; CPU-NEXT: bl {{_?foo_half}}
80-
; CPU: fmov d0, [[REG1]]
81-
; CPU: fmov d1, [[REG2]]
82-
83-
; NOTATTR: fmov [[REG2:s[0-9]+]], s3
84-
; NOTATTR: fmov [[REG1:s[0-9]+]], s2
85-
; NOTATTR: fmov s0, s2
86-
; NOTATTR: fmov s1, s3
87-
; NOTATTR-NEXT: bl {{_?foo_half}}
88-
; NOTATTR: fmov s0, [[REG1]]
89-
; NOTATTR: fmov s1, [[REG2]]
90-
9157
; ATTR: fmov d0, d2
9258
; ATTR: fmov d1, d3
9359
; ATTR: fmov [[REG2:d[0-9]+]], d3

0 commit comments

Comments
 (0)