Skip to content

Commit 53927c1

Browse files
committed
[TextAPI] Seperate out Arch name from enum label, NFCI (llvm#152332)
The enum label e.g. `AK_arm64` is often the same as the architecture name, but doesn't have to be. Seperate it out. (cherry picked from commit 477a65a)
1 parent f922462 commit 53927c1

File tree

4 files changed

+23
-23
lines changed

4 files changed

+23
-23
lines changed

llvm/include/llvm/TextAPI/Architecture.def

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,33 +13,33 @@
1313
///
1414
/// X86 architectures sorted by cpu type and sub type id.
1515
///
16-
ARCHINFO(i386, MachO::CPU_TYPE_I386, MachO::CPU_SUBTYPE_I386_ALL, 32)
17-
ARCHINFO(x86_64, MachO::CPU_TYPE_X86_64, MachO::CPU_SUBTYPE_X86_64_ALL, 64)
18-
ARCHINFO(x86_64h, MachO::CPU_TYPE_X86_64, MachO::CPU_SUBTYPE_X86_64_H, 64)
16+
ARCHINFO(i386, i386, MachO::CPU_TYPE_I386, MachO::CPU_SUBTYPE_I386_ALL, 32)
17+
ARCHINFO(x86_64, x86_64, MachO::CPU_TYPE_X86_64, MachO::CPU_SUBTYPE_X86_64_ALL, 64)
18+
ARCHINFO(x86_64h, x86_64h, MachO::CPU_TYPE_X86_64, MachO::CPU_SUBTYPE_X86_64_H, 64)
1919

2020

2121
///
2222
/// ARM architectures sorted by cpu sub type id.
2323
///
24-
ARCHINFO(armv4t, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V4T, 32)
25-
ARCHINFO(armv6, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V6, 32)
26-
ARCHINFO(armv5, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V5TEJ, 32)
27-
ARCHINFO(armv7, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V7, 32)
28-
ARCHINFO(armv7s, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V7S, 32)
29-
ARCHINFO(armv7k, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V7K, 32)
30-
ARCHINFO(armv6m, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V6M, 32)
31-
ARCHINFO(armv7m, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V7M, 32)
32-
ARCHINFO(armv7em, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V7EM, 32)
24+
ARCHINFO(armv4t, armv4t, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V4T, 32)
25+
ARCHINFO(armv6, armv6, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V6, 32)
26+
ARCHINFO(armv5, armv5, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V5TEJ, 32)
27+
ARCHINFO(armv7, armv7, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V7, 32)
28+
ARCHINFO(armv7s, armv7s, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V7S, 32)
29+
ARCHINFO(armv7k, armv7k, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V7K, 32)
30+
ARCHINFO(armv6m, armv6m, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V6M, 32)
31+
ARCHINFO(armv7m, armv7m, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V7M, 32)
32+
ARCHINFO(armv7em, armv7em, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V7EM, 32)
3333

3434

3535
///
3636
/// ARM64 architectures sorted by cpu sub type id.
3737
///
38-
ARCHINFO(arm64, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64_ALL, 64)
39-
ARCHINFO(arm64e, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64E, 64)
38+
ARCHINFO(arm64, arm64, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64_ALL, 64)
39+
ARCHINFO(arm64e, arm64e, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64E, 64)
4040

4141

4242
///
4343
/// ARM64_32 architectures sorted by cpu sub type id
4444
///
45-
ARCHINFO(arm64_32, MachO::CPU_TYPE_ARM64_32, MachO::CPU_SUBTYPE_ARM64_32_V8, 32)
45+
ARCHINFO(arm64_32, arm64_32, MachO::CPU_TYPE_ARM64_32, MachO::CPU_SUBTYPE_ARM64_32_V8, 32)

llvm/include/llvm/TextAPI/Architecture.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ namespace MachO {
2626

2727
/// Defines the architecture slices that are supported by Text-based Stub files.
2828
enum Architecture : uint8_t {
29-
#define ARCHINFO(Arch, Type, SubType, NumBits) AK_##Arch,
29+
#define ARCHINFO(Arch, Name, Type, SubType, NumBits) AK_##Arch,
3030
#include "llvm/TextAPI/Architecture.def"
3131
#undef ARCHINFO
3232
AK_unknown, // this has to go last.

llvm/lib/TextAPI/Architecture.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace llvm {
2121
namespace MachO {
2222

2323
Architecture getArchitectureFromCpuType(uint32_t CPUType, uint32_t CPUSubType) {
24-
#define ARCHINFO(Arch, Type, Subtype, NumBits) \
24+
#define ARCHINFO(Arch, Name, Type, Subtype, NumBits) \
2525
if (CPUType == (Type) && \
2626
(CPUSubType & ~MachO::CPU_SUBTYPE_MASK) == (Subtype)) \
2727
return AK_##Arch;
@@ -33,17 +33,17 @@ Architecture getArchitectureFromCpuType(uint32_t CPUType, uint32_t CPUSubType) {
3333

3434
Architecture getArchitectureFromName(StringRef Name) {
3535
return StringSwitch<Architecture>(Name)
36-
#define ARCHINFO(Arch, Type, Subtype, NumBits) .Case(#Arch, AK_##Arch)
36+
#define ARCHINFO(Arch, Name, Type, Subtype, NumBits) .Case(#Name, AK_##Arch)
3737
#include "llvm/TextAPI/Architecture.def"
3838
#undef ARCHINFO
3939
.Default(AK_unknown);
4040
}
4141

4242
StringRef getArchitectureName(Architecture Arch) {
4343
switch (Arch) {
44-
#define ARCHINFO(Arch, Type, Subtype, NumBits) \
44+
#define ARCHINFO(Arch, Name, Type, Subtype, NumBits) \
4545
case AK_##Arch: \
46-
return #Arch;
46+
return #Name;
4747
#include "llvm/TextAPI/Architecture.def"
4848
#undef ARCHINFO
4949
case AK_unknown:
@@ -57,7 +57,7 @@ StringRef getArchitectureName(Architecture Arch) {
5757

5858
std::pair<uint32_t, uint32_t> getCPUTypeFromArchitecture(Architecture Arch) {
5959
switch (Arch) {
60-
#define ARCHINFO(Arch, Type, Subtype, NumBits) \
60+
#define ARCHINFO(Arch, Name, Type, Subtype, NumBits) \
6161
case AK_##Arch: \
6262
return std::make_pair(Type, Subtype);
6363
#include "llvm/TextAPI/Architecture.def"
@@ -77,7 +77,7 @@ Architecture mapToArchitecture(const Triple &Target) {
7777

7878
bool is64Bit(Architecture Arch) {
7979
switch (Arch) {
80-
#define ARCHINFO(Arch, Type, Subtype, NumBits) \
80+
#define ARCHINFO(Arch, Name, Type, Subtype, NumBits) \
8181
case AK_##Arch: \
8282
return NumBits == 64;
8383
#include "llvm/TextAPI/Architecture.def"

llvm/lib/TextAPI/TextStubCommon.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ QuotingType ScalarTraits<PlatformSet>::mustQuote(StringRef) {
133133

134134
void ScalarBitSetTraits<ArchitectureSet>::bitset(IO &IO,
135135
ArchitectureSet &Archs) {
136-
#define ARCHINFO(arch, type, subtype, numbits) \
136+
#define ARCHINFO(arch, name, type, subtype, numbits) \
137137
IO.bitSetCase(Archs, #arch, 1U << static_cast<int>(AK_##arch));
138138
#include "llvm/TextAPI/Architecture.def"
139139
#undef ARCHINFO

0 commit comments

Comments
 (0)