Merge pull request #11430 from adrian-prantl/rebranch-str

adrian-prantl · web-flow · commit 66d9f3846081 · 2025-09-16T17:49:51.000-07:00
[lldb] Use SmallString.str() to ensure NUL-termination
diff --git a/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp b/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp
@@ -2980,7 +2980,7 @@ lldb::TypeSystemSP SwiftASTContext::CreateInstance(
             os << llvm::Triple::getOSTypeName(preferred_triple.getOS());
             os << platform_version.getAsString();
           }
-          computed_triple = llvm::Triple(buffer.data());
+          computed_triple = llvm::Triple(buffer.str());
         } else if (preferred_triple.getObjectFormat() == llvm::Triple::MachO) {
           LOG_PRINTF(GetLog(LLDBLog::Types),
                      "Completing triple based on main binary load commands.");

Original file line number	Diff line number	Diff line change
`@@ -2980,7 +2980,7 @@ lldb::TypeSystemSP SwiftASTContext::CreateInstance(`
`2980`	`2980`	`os << llvm::Triple::getOSTypeName(preferred_triple.getOS());`
`2981`	`2981`	`os << platform_version.getAsString();`
`2982`	`2982`	`}`
`2983`		`- computed_triple = llvm::Triple(buffer.data());`
	`2983`	`+ computed_triple = llvm::Triple(buffer.str());`
`2984`	`2984`	`} else if (preferred_triple.getObjectFormat() == llvm::Triple::MachO) {`
`2985`	`2985`	`LOG_PRINTF(GetLog(LLDBLog::Types),`
`2986`	`2986`	`"Completing triple based on main binary load commands.");`