Don't allow null diagnoastics in DiagnosticManager

adrian-prantl · adrian-prantl · commit 6d92da4a5f9b · 2023-04-21T08:25:26.000-07:00
diff --git a/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp b/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp
@@ -2855,7 +2855,8 @@ class StoringDiagnosticConsumer : public swift::DiagnosticConsumer {
   }
 
   void AddDiagnostic(std::unique_ptr<Diagnostic> diagnostic) {
-    m_diagnostics.push_back(std::move(diagnostic));
+    if (diagnostic)
+      m_diagnostics.push_back(std::move(diagnostic));
   }
 
 private:

Original file line number	Diff line number	Diff line change
`@@ -2855,7 +2855,8 @@ class StoringDiagnosticConsumer : public swift::DiagnosticConsumer {`
`2855`	`2855`	`}`
`2856`	`2856`
`2857`	`2857`	`void AddDiagnostic(std::unique_ptr<Diagnostic> diagnostic) {`
`2858`		`- m_diagnostics.push_back(std::move(diagnostic));`
	`2858`	`+ if (diagnostic)`
	`2859`	`+ m_diagnostics.push_back(std::move(diagnostic));`
`2859`	`2860`	`}`
`2860`	`2861`
`2861`	`2862`	`private:`