Merge pull request #10054 from adrian-prantl/warnings

Fix warnings (NFC)

Author: adrian-prantl

lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp

@@ -3889,7 +3889,7 @@ llvm::Expected<swift::ModuleDecl &> SwiftASTContext::CreateModule(
   if (module_name.empty())
     return llvm::createStringError("invalid module name (empty)");
 
-  if (swift::ModuleDecl *module_decl = GetCachedModule(module_name))
+  if (GetCachedModule(module_name))
     return llvm::createStringError(
         llvm::formatv("module already exists for \"{0}\"", module_name));
 
@@ -4653,7 +4653,7 @@ void SwiftASTContext::CacheDemangledTypeFailure(ConstString name) {
 /// specializations.
 static swift::Type ConvertSILFunctionTypesToASTFunctionTypes(swift::Type t) {
   return t.transformRec([](swift::TypeBase *t) -> std::optional<swift::Type> {
-    if (auto *silFn = swift::dyn_cast<swift::SILFunctionType>(t)) {
+    if (swift::dyn_cast<swift::SILFunctionType>(t)) {
       // FIXME: Verify ExtInfo state is correct, not working by accident.
       swift::FunctionType::ExtInfo info;
       return swift::Type(
@@ -6093,6 +6093,7 @@ SwiftASTContext::GetTypeInfo(opaque_compiler_type_t type,
   case swift::TypeKind::ErrorUnion:
   case swift::TypeKind::InOut:
   case swift::TypeKind::Integer:
+  case swift::TypeKind::Locatable:
   case swift::TypeKind::Module:
   case swift::TypeKind::OpenedArchetype:
   case swift::TypeKind::ParameterizedProtocol:
@@ -6254,6 +6255,7 @@ lldb::TypeClass SwiftASTContext::GetTypeClass(opaque_compiler_type_t type) {
   case swift::TypeKind::BuiltinPackIndex:    
   case swift::TypeKind::BuiltinTuple:
   case swift::TypeKind::BuiltinUnboundGeneric:
+  case swift::TypeKind::Locatable:
   case swift::TypeKind::Integer:
   case swift::TypeKind::Pack:
   case swift::TypeKind::PackElement:
@@ -6752,6 +6754,7 @@ lldb::Encoding SwiftASTContext::GetEncoding(opaque_compiler_type_t type,
   case swift::TypeKind::BuiltinRawUnsafeContinuation:
   case swift::TypeKind::Error:
   case swift::TypeKind::InOut:
+  case swift::TypeKind::Locatable:
   case swift::TypeKind::Module:
   case swift::TypeKind::BuiltinPackIndex:
   case swift::TypeKind::Pack:
@@ -6877,6 +6880,7 @@ SwiftASTContext::GetNumChildren(opaque_compiler_type_t type,
   case swift::TypeKind::GenericTypeParam:
   case swift::TypeKind::InOut:
   case swift::TypeKind::Integer:
+  case swift::TypeKind::Locatable:
   case swift::TypeKind::Metatype:
   case swift::TypeKind::Module:
   case swift::TypeKind::OpaqueTypeArchetype:
@@ -7011,6 +7015,7 @@ uint32_t SwiftASTContext::GetNumFields(opaque_compiler_type_t type,
   case swift::TypeKind::ErrorUnion:
   case swift::TypeKind::InOut:
   case swift::TypeKind::Integer:
+  case swift::TypeKind::Locatable:
   case swift::TypeKind::Module:
   case swift::TypeKind::Pack:
   case swift::TypeKind::PackArchetype:
@@ -7242,6 +7247,7 @@ CompilerType SwiftASTContext::GetFieldAtIndex(opaque_compiler_type_t type,
   case swift::TypeKind::ErrorUnion:
   case swift::TypeKind::InOut:
   case swift::TypeKind::Integer:
+  case swift::TypeKind::Locatable:
   case swift::TypeKind::Module:
   case swift::TypeKind::Pack:
   case swift::TypeKind::PackArchetype:
@@ -7449,6 +7455,7 @@ uint32_t SwiftASTContext::GetNumPointeeChildren(opaque_compiler_type_t type) {
   case swift::TypeKind::GenericTypeParam:
   case swift::TypeKind::InOut:
   case swift::TypeKind::Integer:
+  case swift::TypeKind::Locatable:
   case swift::TypeKind::Metatype:
   case swift::TypeKind::Module:
   case swift::TypeKind::OpaqueTypeArchetype:
@@ -7609,6 +7616,7 @@ llvm::Expected<CompilerType> SwiftASTContext::GetChildCompilerTypeAtIndex(
   case swift::TypeKind::GenericTypeParam:
   case swift::TypeKind::InOut:
   case swift::TypeKind::Integer:
+  case swift::TypeKind::Locatable:
   case swift::TypeKind::Metatype:
   case swift::TypeKind::Module:
   case swift::TypeKind::OpaqueTypeArchetype:
@@ -7959,6 +7967,7 @@ size_t SwiftASTContext::GetIndexOfChildMemberWithName(
     case swift::TypeKind::GenericFunction:
     case swift::TypeKind::InOut:
     case swift::TypeKind::Integer:
+    case swift::TypeKind::Locatable:
     case swift::TypeKind::Metatype:
     case swift::TypeKind::Module:
     case swift::TypeKind::OpaqueTypeArchetype:
@@ -8201,8 +8210,7 @@ SwiftASTContext::GetGenericArgumentKind(opaque_compiler_type_t type,
                                         size_t idx) {
   VALID_OR_RETURN_CHECK_TYPE(type, eNullGenericKindType);
   swift::CanType swift_can_type(GetCanonicalSwiftType(type));
-  if (auto *unbound_generic_type =
-          swift_can_type->getAs<swift::UnboundGenericType>())
+  if (swift_can_type->getAs<swift::UnboundGenericType>())
     return eUnboundGenericKindType;
   if (auto *bound_generic_type =
           swift_can_type->getAs<swift::BoundGenericType>())
@@ -8314,8 +8322,6 @@ bool SwiftASTContext::IsMeaninglessWithoutDynamicResolution(
 //----------------------------------------------------------------------
 // Dumping types
 //----------------------------------------------------------------------
-#define DEPTH_INCREMENT 2
-
 #ifndef NDEBUG
 LLVM_DUMP_METHOD void SwiftASTContext::dump(opaque_compiler_type_t type) const {
   if (!type)
@@ -8355,6 +8361,7 @@ bool SwiftASTContext::DumpTypeValue(
   case swift::TypeKind::Existential:
   case swift::TypeKind::InOut:
   case swift::TypeKind::Integer:
+  case swift::TypeKind::Locatable:
   case swift::TypeKind::Module:
   case swift::TypeKind::Pack:
   case swift::TypeKind::PackArchetype: