Skip to content

Commit 8e34d65

Browse files
committed
[test] llvm-ar: Fix inadvertent unXFAIL for Apple platforms
The history of these XFAILs is clouded. Initially added as target-based checks in llvm@629273e for somewhat vague reasons, soon after switched to host-based checks in llvm@20b2cd3 "due to the problem being related to the darwin host and not the target", and recently reverted back to target-based in llvm#130144 because, to my understanding, the tests can unexpectedly pass on arm64 macOS with `llvm-ar` cross-compiled to baremetal arm64. Anyway, the problem with the current `target={{.*}}-darwin{{.*}}` is that the Swift build script uses Apple platform names like 'macosx', not 'darwin', for the LLVM target triple, e.g. `arm64-apple-macosx13.0`.
1 parent f1b4a3b commit 8e34d65

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

llvm/test/tools/llvm-ar/extract.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
## Test extract operation.
2-
# XFAIL: target={{.*}}-darwin{{.*}}
2+
# XFAIL: target={{.*}}-apple-{{.*}}
33

44
# RUN: rm -rf %t && mkdir -p %t/extracted/
55

llvm/test/tools/llvm-ar/print.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
## Test Print output
2-
# XFAIL: target={{.*}}-darwin{{.*}}
2+
# XFAIL: target={{.*}}-apple-{{.*}}
33

44
# RUN: rm -rf %t && mkdir -p %t
55
# RUN: echo file1 > %t/1.txt

0 commit comments

Comments
 (0)