Simplify initializers (NFC)

Author: adrian-prantl

lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp

@@ -2722,8 +2722,7 @@ class ANSIColorStringStream : public llvm::raw_string_ostream {
 class StoringDiagnosticConsumer : public swift::DiagnosticConsumer {
 public:
   StoringDiagnosticConsumer(SwiftASTContext &ast_context)
-      : m_ast_context(ast_context), m_raw_diagnostics(), m_diagnostics(),
-        m_num_errors(0), m_colorize(false) {
+      : m_ast_context(ast_context) {
     m_ast_context.GetDiagnosticEngine().resetHadAnyError();
     m_ast_context.GetDiagnosticEngine().addConsumer(*this);
   }
@@ -2981,11 +2980,8 @@ class StoringDiagnosticConsumer : public swift::DiagnosticConsumer {
                   uint32_t in_line, uint32_t in_column,
                   llvm::ArrayRef<swift::Diagnostic::FixIt> in_fixits)
         : description(in_desc), kind(in_kind), bufferName(in_bufferName),
-          bufferID(in_bufferID), line(in_line), column(in_column) {
-      for (auto fixit : in_fixits) {
-        fixits.push_back(fixit);
-      }
-    }
+          bufferID(in_bufferID), line(in_line), column(in_column),
+          fixits(in_fixits) {}
     std::string description;
     swift::DiagnosticKind kind;
     const llvm::StringRef bufferName;
@@ -3002,7 +2998,7 @@ class StoringDiagnosticConsumer : public swift::DiagnosticConsumer {
   DiagnosticList m_diagnostics;
 
   unsigned m_num_errors = 0;
-  bool m_colorize;
+  bool m_colorize = false;
 };
 
 } // namespace lldb_private