Skip to content

Commit b3e5295

Browse files
committed
[lldb] Use ${CMAKE_COMMAND} -E remove instead of remove_directory
We no longer need to remove a directory downstream and also contrary to my previous observations, remove_directory isn't sufficient to remove a regular file. Differential revision: https://reviews.llvm.org/D143024 (cherry picked from commit 9f8fd57)
1 parent 82c8ea3 commit b3e5295

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

lldb/cmake/modules/AddLLDB.cmake

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,10 +301,8 @@ function(lldb_add_to_buildtree_lldb_framework name subdir)
301301

302302
# Create a custom target to remove the copy again from LLDB.framework in the
303303
# build tree.
304-
# Intentionally use remove_directory because the target can be a either a
305-
# file or directory and using remove_directory is harmless for files.
306304
add_custom_target(${name}-cleanup
307-
COMMAND ${CMAKE_COMMAND} -E remove_directory ${copy_dest}
305+
COMMAND ${CMAKE_COMMAND} -E remove ${copy_dest}
308306
COMMENT "Removing ${name} from LLDB.framework")
309307
add_dependencies(lldb-framework-cleanup
310308
${name}-cleanup)

0 commit comments

Comments
 (0)