Skip to content

Commit b667b39

Browse files
eronnenJDevlieghere
authored andcommitted
[lldb-dap] improve symbol table style (llvm#155097)
* apply odd table rows color from vscode theme * apply hover color from vscode theme [Screencast From 2025-08-23 14-48-44.webm](https://github.com/user-attachments/assets/a738ac3c-3e56-4a57-b713-7430c614c415) (cherry picked from commit 3cbbc07)
1 parent d54de4a commit b667b39

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

lldb/tools/lldb-dap/src-ts/ui/symbols-webview-html.ts

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,13 @@ export function getSymbolsTableHTMLContent(tabulatorJsPath: vscode.Uri, tabulato
1212
color: var(--vscode-editor-foreground);
1313
}
1414
15+
.tabulator .tabulator-header {
16+
background-color: var(--vscode-tree-tableOddRowsBackground);
17+
color: var(--vscode-editor-foreground);
18+
}
19+
1520
.tabulator .tabulator-header .tabulator-col {
16-
background-color: var(--vscode-editor-background);
21+
background-color: var(--vscode-tree-tableOddRowsBackground);
1722
color: var(--vscode-editor-foreground);
1823
}
1924
@@ -23,11 +28,22 @@ export function getSymbolsTableHTMLContent(tabulatorJsPath: vscode.Uri, tabulato
2328
}
2429
2530
.tabulator-row.tabulator-row-even {
31+
background-color: var(--vscode-tree-tableOddRowsBackground);
32+
}
33+
34+
@media (hover:hover) and (pointer:fine){
35+
.tabulator-row:hover {
36+
background-color: var(--vscode-list-hoverBackground);
37+
color: var(--vscode-list-hoverForeground);
38+
}
39+
}
40+
41+
.tabulator-row.tabulator-selected {
2642
background-color: var(--vscode-editor-background);
2743
color: var(--vscode-editor-foreground);
2844
}
2945
30-
.tabulator-row.tabulator-selected {
46+
.tabulator .tabulator-tableholder .tabulator-table {
3147
background-color: var(--vscode-editor-background);
3248
color: var(--vscode-editor-foreground);
3349
}

lldb/tools/lldb-dap/src-ts/webview/symbols-table-view.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ const SYMBOLS_TABLE = new Tabulator("#symbols-table", {
9595
height: "100vh",
9696
columns: SYMBOL_TABLE_COLUMNS,
9797
layout: "fitColumns",
98+
selectableRows: false,
9899
data: previousState?.symbols || [],
99100
});
100101

0 commit comments

Comments
 (0)