Pass argument by reference to a void a use-after-free.

adrian-prantl · adrian-prantl · commit bb651430a26f · 2023-03-09T09:16:49.000-08:00
rdar://106464908
diff --git a/lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp b/lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
@@ -3367,7 +3367,7 @@ CompilerType TypeSystemSwiftTypeRef::CreateSILPackType(CompilerType type,
 }
 
 static llvm::Optional<TypeSystemSwiftTypeRef::PackTypeInfo>
-decodeSILPackType(swift::Demangle::Demangler dem, CompilerType type,
+decodeSILPackType(swift::Demangle::Demangler &dem, CompilerType type,
                   swift::Demangle::NodePointer &node) {
   TypeSystemSwiftTypeRef::PackTypeInfo info;
   node = GetDemangledType(dem, type.GetMangledTypeName().GetStringRef());

Original file line number	Diff line number	Diff line change
`@@ -3367,7 +3367,7 @@ CompilerType TypeSystemSwiftTypeRef::CreateSILPackType(CompilerType type,`
`3367`	`3367`	`}`
`3368`	`3368`
`3369`	`3369`	`static llvm::Optional<TypeSystemSwiftTypeRef::PackTypeInfo>`
`3370`		`-decodeSILPackType(swift::Demangle::Demangler dem, CompilerType type,`
	`3370`	`+decodeSILPackType(swift::Demangle::Demangler &dem, CompilerType type,`
`3371`	`3371`	`swift::Demangle::NodePointer &node) {`
`3372`	`3372`	`TypeSystemSwiftTypeRef::PackTypeInfo info;`
`3373`	`3373`	`node = GetDemangledType(dem, type.GetMangledTypeName().GetStringRef());`